Skip to content

DEV-220 S3R ExG support in Consensys config screen#209

Merged
JongChern merged 2 commits intomasterfrom
DEV-220
Apr 8, 2025
Merged

DEV-220 S3R ExG support in Consensys config screen#209
JongChern merged 2 commits intomasterfrom
DEV-220

Conversation

@marknolan
Copy link
Copy Markdown
Member

  • Updated ExG channels for S3R ExG support
  • removed S3R proto3 mini as there won't be any
  • refactoring to remove "NewIMU" from names as that doesn't apply to S3R

@marknolan marknolan requested review from JongChern and Copilot April 7, 2025 10:12
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (4)

ShimmerDriver/src/main/java/com/shimmerresearch/driver/Configuration.java:1349

  • [nitpick] Ensure that renaming to remove 'NewImu' from S3R variables is applied consistently across all S3R definitions; for instance, verify if 'svoShimmer3RGsrNewImuLogAndStream' should also be renamed accordingly.
private static final ShimmerVerObject svoShimmer3RExgUnifiedLogAndStream = new ShimmerVerObject(HW_ID.SHIMMER_3R,FW_ID.LOGANDSTREAM,0,1,0,HW_ID_SR_CODES.EXP_BRD_EXG_UNIFIED, NEW_IMU_EXP_REV.EXG_UNIFIED);

ShimmerDriver/src/main/java/com/shimmerresearch/driver/Configuration.java:1372

  • [nitpick] Confirm that the removal of 'NewImu' is intended here and consider whether the NEW_IMU_EXP_REV parameter should be updated to reflect the naming change.
private static final ShimmerVerObject svoShimmer3RBrAmpUnifiedLogAndStream = new ShimmerVerObject(HW_ID.SHIMMER_3R,FW_ID.LOGANDSTREAM,0,1,0,HW_ID_SR_CODES.EXP_BRD_BR_AMP_UNIFIED, NEW_IMU_EXP_REV.BRIDGE_AMP);

ShimmerDriver/src/main/java/com/shimmerresearch/driver/Configuration.java:1385

  • [nitpick] Verify the updated variable name adheres to the overall naming conventions now that 'NewImu' has been removed, ensuring alignment with related S3R definitions.
private static final ShimmerVerObject svoShimmer3RProto3DeluxeLogAndStream =new ShimmerVerObject(HW_ID.SHIMMER_3R,FW_ID.LOGANDSTREAM,0,1,0,HW_ID_SR_CODES.EXP_BRD_PROTO3_DELUXE, NEW_IMU_EXP_REV.PROTO3_DELUXE);

ShimmerDriver/src/main/java/com/shimmerresearch/driver/Configuration.java:1410

  • [nitpick] Confirm that the inclusion of 'svoShimmer3RExgUnifiedLogAndStream' in the ExG compatibility lists is consistent with the refactoring intent, and that all S3R-specific entries have been uniformly updated.
svoShimmerECGmd, svoShimmer4Stock, svoStrokare, svoShimmer3RExgUnifiedLogAndStream

@JongChern
Copy link
Copy Markdown
Collaborator

looks good

@JongChern JongChern merged commit c44a3bb into master Apr 8, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants