DEV-216 clear CRC bytes for instream commands

[marknolan]

No description provided.

[Copilot]

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

ShimmerDriver/src/main/java/com/shimmerresearch/bluetooth/ShimmerBluetooth.java:1092

• [nitpick] Consider renaming the 'clearCrcBytes' parameter to something more descriptive, such as 'shouldClearCrcFromBuffer', to clarify its purpose.

protected void processInstreamResponse(boolean clearCrcBytes) {

[marknolan]

Just to note, a better approach would be to actually check the CRC in the instream response parsing:
https://github.com/ShimmerEngineering/Shimmer-Java-Android-API/blob/5713c85282388263c12d30c7e46a9cbdb2ee6d45/ShimmerDriver/src/main/java/com/shimmerresearch/bluetooth/ShimmerBluetooth.java#L1152

And in the other response parsing:
https://github.com/ShimmerEngineering/Shimmer-Java-Android-API/blob/5713c85282388263c12d30c7e46a9cbdb2ee6d45/ShimmerDriver/src/main/java/com/shimmerresearch/bluetooth/ShimmerBluetooth.java#L1861

but this would involve a much larger update as there are some command that don't have a fixed number of bytes in the response so they would all have to be managed individually while also having to manage what happens if/when the CRC check fails.

[JongChern]

ok looks good and tested