VCBA-47 added comm type to config byte parse/generate methods#61
Merged
VCBA-47 added comm type to config byte parse/generate methods#61
Conversation
marknolan
changed the title
Collaborator
|
ok looks good, no objections |
JongChern
approved these changes
Aug 23, 2021
JongChern
added a commit
that referenced
this pull request
Feb 6, 2024
…ingPerCommType VCBA-47 added comm type to config byte parse/generate methods
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@JongChern would you be ok with this change? this would allow us to use the existing configBytesParse and configBytesGenerate methods for VerisenseDevice but we can choose to parse the bytes differently whether they are from the bin file in the payload header (COMMUNICATION_TYPE.SD) or from the operational config bytes (COMMUNICATION_TYPE.BLUETOOH).
I've put in the original method calls in ShimmerDevice and therefore it won't cause any customers any issues when updating to a newer version of the driver.