Conversation
mlclay
suggested changes
Jan 28, 2020
Contributor
mlclay
left a comment
mlclay
left a comment
There was a problem hiding this comment.
This adds another way to cleanly inject the json_asserter for use in pytests. I think this could be useful. Since this is the one part of shipchain-common that is currently documented, can you please update the readme with a snippet on using this mixin
mlclay
approved these changes
Jan 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a Json Asserter mixin that automatically grabs the json_asserter and sets it's value on the class, so importing it every time isn't necessary.