fix: add organization-level access control to human-inputs endpoints#264
Merged
betterclever merged 1 commit intomainfrom Feb 4, 2026
Merged
fix: add organization-level access control to human-inputs endpoints#264betterclever merged 1 commit intomainfrom
betterclever merged 1 commit intomainfrom
Conversation
- Add organization filtering to list(), getById(), resolve() methods - Enforce authentication and organizationId validation in controller - Prevent cross-organization approval access (IDOR vulnerability) - Add comprehensive unit tests for IDOR protection Fixes: Approval data was visible across all organizations Signed-off-by: betterclever <paliwal.pranjal83@gmail.com> Amp-Thread-ID: https://ampcode.com/threads/T-019c2a28-b06a-742a-a3bb-019eda8d723f Co-authored-by: Amp <amp@ampcode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a critical IDOR vulnerability in the human-inputs (approvals) endpoints.
Problem
Approval requests were visible and accessible across all organizations, allowing users to:
Solution
@CurrentAuth()decorator pattern consistent with the codebaseUnauthorizedExceptionif auth context or organizationId is missingChanges
Files Modified
backend/src/human-inputs/human-inputs.controller.tsbackend/src/human-inputs/human-inputs.service.tsbackend/src/human-inputs/__tests__/human-inputs.service.test.ts(new)Verification
✅ All tests pass (499 pass, 0 fail)
✅ Typecheck passes
✅ Lint passes (with fix)