fix(release): make workflow idempotent and resilient#291
Merged
Conversation
- Replace softprops/action-gh-release with gh CLI to handle existing releases (update instead of fail on re-runs) - Add continue-on-error to version bump step so Docker image pushes aren't marked as failed when the PR step has issues Signed-off-by: Aseem Shrey <LuD1161@users.noreply.github.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: db9f37fed9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Append workflow run ID to the bump branch name so re-running the release for the same version doesn't fail due to branch conflicts. Also cleans up any stale bump branches from previous runs. Signed-off-by: Aseem Shrey <LuD1161@users.noreply.github.com>
LuD1161
force-pushed
the
LuD1161/fix-release-workflow
branch
from
db9f37f to
8327ddc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
continue-on-error: trueto the version bump step so the workflow reports success when Docker images are pushed, even if the PR creation has issuesContext
When re-running the release workflow for v0.2.1, the
softprops/action-gh-releaseaction would overwrite manually written release notes. Replaced it withghCLI that checks if a release exists first and updates it. Also, the version bump step failure was causing the entire workflow to be marked as failed even though Docker images were pushed successfully.Test plan