Conversation
Signed-off-by: Aseem Shrey <LuD1161@users.noreply.github.com>
…ading Signed-off-by: Aseem Shrey <LuD1161@users.noreply.github.com>
- Adjust dark mode --muted and --accent HSL values for better contrast - Add scrollbar-hide utility class - Add highlight-fade animation for new findings in security dashboard Signed-off-by: Aseem Shrey <LuD1161@users.noreply.github.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cf4e09a7d6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…kflow
- navigate('/builder') → navigate('/') on workflow load failure (/builder doesn't exist)
- Scope inflightRef dedup to current workflowId to prevent stale schedule data when switching workflows
Signed-off-by: Aseem Shrey <LuD1161@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
React.lazy()withSuspense, reducing initial bundle size/workflows/summaryendpoint returns workflow metadata without full graph data@shipsec/sharedreplaces 5+ duplicated arraysPerformance Impact
1. Temporal RPC Reduction (Run Status Cache)
getRunStatus()for completed runReal-world estimate: A workflow list page with 50 runs where 45 are terminal goes from 45 Temporal RPCs (~4.5-9s) → 0 Temporal RPCs (~0.1-0.2s) for status resolution.
2. Frontend Bundle / Load Time
React.lazy()importsStrictModein prod3. API Call Reduction
GET /workflows(full graph data)GET /workflows/summary(metadata only)workflows.list()workflows.listSummary()4. Payload Size Estimates
/workflowsresponse/workflows/summaryresponse/workflows/runs(initial)5. Polling Efficiency
isRunLivecheckexecutionRuns.tsNet Effect (Estimated)
Test plan
run-status-cache.spec.tstests covering cache-hit, cache-miss, and Temporal-not-found scenariosworkflows.service.spec.tsupdated withcacheTerminalStatusmock