Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cf1cbeac16
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
frontend/src/features/workflow-builder/hooks/useWorkflowExecutionLifecycle.ts
Outdated
Show resolved
Hide resolved
… domains - Install @tanstack/react-query, add QueryClient and QueryClientProvider - Create org-scoped query key factories in queryKeys.ts - Create queryOptions() factories for execution data in executionQueryOptions.ts - Add query hooks for all server-state domains: runs, workflows, executions, components, integrations, MCP groups/servers, schedules, secrets, webhooks, API keys, artifacts, and human input - Export TerminalChunkResponse from api.ts for queryOptions type inference - Add mcpGroupsApi service for N+1 batch endpoints Signed-off-by: Aseem Shrey <LuD1161@users.noreply.github.com>
cf1cbea to
48e29f9
Compare
48e29f9 to
25b615b
Compare
…e Zustand stores - Migrate all pages, components, and features from Zustand stores to query hooks - Route execution/timeline Zustand stores through queryOptions() factories - Delete 11 Zustand stores (apiKey, artifact, component, integration, mcpGroup, mcpServer, run, schedule, secret, webhook) and their tests - Update remaining tests to work with TanStack Query patterns - Fix N+1 query patterns on WorkflowList and MCP Library pages (backend batch endpoints) Signed-off-by: Aseem Shrey <LuD1161@users.noreply.github.com>
…ackend batch endpoints - Add idle-time prefetching for components and workflows via requestIdleCallback - Optimize bundle with manual chunks, font preloading, and lazy route loading - Add backend batch endpoints for workflow summaries and MCP group server counts - Gate prefetch on auth state and align cache shapes to prevent mismatches - Add VITE_DISABLE_DEVTOOLS env var Signed-off-by: Aseem Shrey <LuD1161@users.noreply.github.com>
25b615b to
c46da6a
Compare
…d load testing audit - Add frontend/docs/performance.md with query hook and rendering guidelines - Update frontend/docs/state.md with TanStack Query migration patterns - Add load testing audit report (2026-02-17) - Add performance-review skill and rename load-audit to stress-test-frontend - Update AGENTS.md with TanStack Query enforcement rules - Update READMEs for hooks and stores Signed-off-by: Aseem Shrey <LuD1161@users.noreply.github.com>
c46da6a to
75230bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrate all frontend server-state from Zustand stores to TanStack Query, with performance optimizations across network, rendering, and bundle loading.
TanStack Query Migration
QueryClient, org-scopedqueryKeysfactory,QueryClientProviderqueryOptions()shared factories for execution data consumed by both React hooks and Zustand store actionsqueryOptions()factoriesPerformance Improvements
components+workflowsSummaryserved from cachestaleTime: Infinityfor components, templates, providersstaleTime: Infinityfor completed/failed/cancelled runsBundle & Loading Optimizations
React.lazy()— initial bundle only loads shell + authvendor-react,vendor-radix,vendor-analytics) for stable browser cachingrequestIdleCallbackfor all sidebar pagescomponentsandworkflowsSummary(gated on auth)<link rel="preload">in index.html4-Tier Stale Time Strategy
Infinity30sInfinitywhen run is finished0Backend
Documentation
frontend/docs/performance.md— authoritative performance guidelinesfrontend/docs/state.mdwith TanStack Query migration patternsTest Plan
tsc --build)