-
Notifications
You must be signed in to change notification settings - Fork 10
fix sprite rendering with melonjs #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fix blinking sprite rendering in the current version.
|
Ahh so cool, noticed by a bigshot 🤩! Thank you very much for the PR fix! |
thanks for merging it as well !! Also, if you update to the latest 14.5 version of melonJS it does provide a nice 17%-25% performance improvements that bring it at least on par with other frameworks for sprite rendering (60fps for all cases, at least on my machine). 10'000 circles are still painful to draw, but getting there too :) [EDIT] here is the detailed test I did : https://melonjs.discourse.group/t/melonjs-benchmark/48 |
|
Hello again! That is very interesting! I have just updated melonJS to the latest version of 14.5 and it seems to be working very well on my machine too. I'll definitely try out melonJS for a project in the future 🙌 Here's a detailed test I did on sprite rendering, there was indeed a significant improvement on the performance! 🤩 |
|
this is awesome ! I'm a bit surprised though that you are not able to get more performance out of your machine, on mine (Apple M1 Max) I'm hitting 60 fps whatever framework I'm trying, but then indeed maybe I should push it to 15'000 for future reference. thank you again for the update, really appreciating it. And next we are working on improving drawing performances for primitive, so you'll definitely hear more from us on the circle fill and stroke test :):):) |
|
My machine doesn't seem to be capable of hitting 60fps on any of the framework tested when going for >= 10'000 sprites sadly haha. M1 does really perform well as the rumours say I guess 🤤 I am glad the benchmark were of some help in contributing to an awesome project such as yours. 😊 I'll be looking forward to the next update, thank you too! 🥳 |
|
Hi @Shirajuki again, By the way, would you mind also add a mention on melonJS in the README ? with melonJS performing at least as well as Phaser on my machine (they all do 60 fps on my side), and If I may ask, melonJS at least deserve to be mentioned here below as well
Thank you very much really ! |
fix blinking sprite rendering in the current version.