Skip to content

feat: add greet function (shmuel max)#5

Merged
ShmuelMax100 merged 2 commits into
mainfrom
feature/shmuel/hello-world
Apr 30, 2026
Merged

feat: add greet function (shmuel max)#5
ShmuelMax100 merged 2 commits into
mainfrom
feature/shmuel/hello-world

Conversation

@ShmuelMax100
Copy link
Copy Markdown
Owner

@ShmuelMax100 ShmuelMax100 commented Apr 30, 2026

Summary

Adds a greet() function that returns a personalised welcome message.
This is the foundation for the onboarding banner we'll add in the next sprint.

Changes

  • src/app.py — new greet(name) function with input validation
  • src/test_app.py — two tests covering the happy path and empty-name edge case

Type of Change

  • Bug fix
  • [x ] New feature
  • Refactor / cleanup
  • CI / tooling
  • Documentation

Testing

Ran the full test suite locally — all 10 tests pass:

cd src && pytest -v
# test_greet PASSED
# test_greet_empty_name PASSED

## Checklist

- [x ] My code follows the project's style guidelines
- [ x] I have added or updated tests where applicable
- [ x] CI checks are passing
- [ x] I have self-reviewed this PR before requesting review
- [ x] Related issues are linked below

## Related Issues

Closes #

@ShmuelMax100 ShmuelMax100 merged commit d787f01 into main Apr 30, 2026
@ShmuelMax100 ShmuelMax100 deleted the feature/shmuel/hello-world branch April 30, 2026 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant