Add hooks for reporting accessibility scroll status#100
Conversation
alinebee
requested review from
raulriera and
robinsenior
and removed request for
raulriera
raulriera
left a comment
raulriera
left a comment
There was a problem hiding this comment.
FunctionalCollectionData is completely missing in this PR.
| } | ||
|
|
||
| return visibleIndexPaths.compactMap { sections[$0] } | ||
| } |
There was a problem hiding this comment.
What value are you getting out of the CellConfigType? are you then casting those to their actual types? I think this bit property be outside of the library tho
raulriera
left a comment
raulriera
left a comment
There was a problem hiding this comment.
Would love for public var visibleRows: [CellConfigType] to be an extension on the actual app we would be using this instead. The rest is 👨🍳👌
robinsenior
left a comment
robinsenior
left a comment
There was a problem hiding this comment.
This is cool, do we have plans to incorporate it for accessibility work internally?
Yup, once this is merged to FTD I have a Polaris PR ready to go up that'll implement accessible scroll descriptions. |
alinebee
force-pushed
the
accessibility-scroll-hooks
branch
from
eef37a0 to
ca08719
Compare
|
I've rebased, removed the |
3 participants
This PR adds an optional callback for
UIAccessibilityScrollViewDelegate.accessibilityScrollStatus, which can be used to report the current scroll position of the table in an accessible way: e.g. "Page 2 of 3" (for general screen content), "Aardvark to Marmoset" (for alphabetised lists), "15th January to 23rd March" (for chronological lists) etc. This is a useful navigational aid for VoiceOver users.This PR also adds a helper method to get all currently-visible cells, which proved useful for constructing these accessibility descriptions.