Conversation
| CLANG_WARN_CONSTANT_CONVERSION = YES; | ||
| CLANG_WARN_CXX0X_EXTENSIONS = YES; | ||
| CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS = YES; | ||
| CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR; |
There was a problem hiding this comment.
did you mean to downgrade this one?
| CLANG_WARN_OBJC_IMPLICIT_ATOMIC_PROPERTIES = YES; | ||
| CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES; | ||
| CLANG_WARN_OBJC_LITERAL_CONVERSION = YES; | ||
| CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR; |
There was a problem hiding this comment.
This also changed to just a warning.
| MTL_ENABLE_DEBUG_INFO = NO; | ||
| SDKROOT = iphoneos; | ||
| SWIFT_OPTIMIZATION_LEVEL = "-Owholemodule"; | ||
| SWIFT_TREAT_WARNINGS_AS_ERRORS = YES; |
There was a problem hiding this comment.
I guess this negates my other comments since this project is 100% Swift. The LLVM warnings are not Swift exclusive though. Some C, Obj-C warnings that were errors may not be now.
Carry on.
There was a problem hiding this comment.
ah.. GCC_TREAT_WARNINGS_AS_ERRORS=YES probably catches those...
Stupid Xcode project files.
There was a problem hiding this comment.
Yeah, I also flipped those... I can revert the changes to the manually error ones just in case tho
There was a problem hiding this comment.
nah... I think it's fine. This project should never have anything but Swift in it anyway.
4 participants
What
Taken a page out of the Webkit book, turning all warnings to yes.