Fix failing typecast in section validation tests#108
Merged
Conversation
sherryshao
approved these changes
Aug 23, 2018
Contributor
sherryshao
left a comment
sherryshao
left a comment
There was a problem hiding this comment.
🙏 apologies for the delayed approval, thanks for fixing!
raulriera
reviewed
Aug 23, 2018
| XCTAssertEqual($0.userInfo!["Duplicates"] as? Set<String>, Set(arrayLiteral: "section1")) | ||
|
|
||
| if let duplicates = $0.userInfo?["Duplicates"] as? [String] { | ||
| XCTAssertEqual(Set(duplicates), Set(["section1"])) |
Contributor
There was a problem hiding this comment.
isn't this always going to make them the same? if duplicates is ["section1", "section1"] it will be collapsed to ["section1"]
Contributor
Author
There was a problem hiding this comment.
duplicates is expected to contain each unique key that was duplicated: one entry per key, not one per section, but we don't care about the number. What we really care about is "does duplicates contain the duplicate key, with no false positives for other keys?"
raulriera
approved these changes
Aug 23, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a conditional cast from
[String]toSet<String>that now (as of Swift 4.2 maybe?) always fails, which was causing a pair of tests to fail.