Fixed background thread access UI component#114
Merged
Conversation
krbarnes
approved these changes
Oct 16, 2018
Contributor
krbarnes
left a comment
krbarnes
left a comment
There was a problem hiding this comment.
I might capture the frame before starting the operation to avoid the sync.
dannbeau
approved these changes
Oct 16, 2018
g-Off
reviewed
Oct 16, 2018
| guard let exceptionHandler = FunctionalTableData.exceptionHandler else { return } | ||
| let changes = TableSectionChangeSet() | ||
| let exception = FunctionalTableData.Exception(name: $0.name.rawValue, newSections: newSections, oldSections: strongSelf.sections, changes: changes, visible: [], viewFrame: strongSelf.collectionView?.frame ?? .zero, reason: $0.reason, userInfo: $0.userInfo) | ||
| var viewFrame: CGRect = .zero |
Contributor
There was a problem hiding this comment.
I think you can write this as:
let viewFrame = DispatchQueue.main.sync { return strongSelf.collectionView?.frame ?? .zero }
I don't think the public func |
stevenwenxu
force-pushed
the
fix-tableview-ui-access
branch
from
8c2371a to
8dfd483
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #113
The
tableView.framewas directly accessed in theBlockOperation. As suggested by the main thread checker, this should only be accessed in the main thread.