Include event type codes for FedEx tracking events

[jonathankwok]

Problem

ShipmentEvents for FedEx weren't initialized with their <EventType>s. This results in no status code being associated with a ShipmentEvent.

Solution

Save the <EventType> , much like we do with USPS ShipmentEvents.

Review: @mdking @lucasuyezu @cyprusad

[kmcphillips]

👍 other than red CI

[jonathankwok]

@kmcphillips Appears that all the fails are related to this change?

My guess is there was some kind of an API change?

[lucasuyezu]

Why are you passing description twice?

[jonathankwok]

It was that, or pass nil. USPS opted to add description twice so I went with that.

[lucasuyezu]

Oh I see. 👍

[cyprusad]

Is that for name and message respectively? https://github.com/Shopify/active_shipping/blob/master/lib/active_shipping/shipment_event.rb#L5

[jonathankwok]

Yeah, it's always been using description for name, I just went ahead and passed description for message as well instead of passing in nil.

[jonathankwok]

After some digging, I've found out that the customer number added in #313 is for contract shipping (see: Test values for contract shipping, rating and returns. The customer number is for contract-shipping, which requires a contract number and a request built for contract-shipping.

Our canada_post_pws.rb uses the non-contracted shipment endpoint, so the credentials provided (and used in Travis) won't work for the failing tests. The only solution I have for now is to go back to the previous behaviour where we skipped those specific failing tests. We'll need different creds if we want those tests to pass - I have no idea how @dangerdogz was able to get them to pass on #313.

[kmcphillips]

Thanks for the digging @jonathankwok. I'm fine with skip since you have made a good case for it.