Add Bolivia (BO) to countries without postal codes#95
Merged
maximebedard merged 1 commit intomasterfrom Aug 15, 2017
Merged
Conversation
Contributor
Author
|
There's tests, just not for every countries https://github.com/Shopify/active_utils/blob/master/test/unit/country_test.rb#L68-L76 This is a config, is it worth testing that the config works? |
jpcaissy
approved these changes
Aug 14, 2017
There was a problem hiding this comment.
I'm ok with this. There is a formal unit test to make sure a country could not require postal codes.
Edit: Double confirmed on UPU and Bolivia doesn't have a postal code on their addressing format: http://www.upu.int/fileadmin/documentsFiles/activities/addressingUnit/bolEn.pdf
Contributor
|
@maximebedard, faster than light. |
itsgarcia
added a commit
that referenced
this pull request
Dec 16, 2018
As per #95 adds Vanuatu (VU) to list of countries not requiring postal codes. Refs: https://en.wikipedia.org/wiki/List_of_postal_codes - indicates no postal codes in Vanuatu https://www.iso.org/obp/ui/#iso:code:3166:VU - ISO code confirmation http://www.upu.int/fileadmin/documentsFiles/activities/addressingUnit/vutEn.pdf - UPU check as per previous review Based on https://github.com/Shopify/shopify/issues/182522
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the list of country codes, Bolivia doesn't require a zip code. I'm simply adding the code to that list.
ref: https://en.wikipedia.org/wiki/List_of_postal_codes
@Shopify/checkout