This repository was archived by the owner on Aug 8, 2022. It is now read-only.
Add ability for Testify to generate companion diff images for failed tests#209
Merged
DanielJette merged 1 commit intomasterfrom Mar 24, 2021
Merged
Add ability for Testify to generate companion diff images for failed tests#209DanielJette merged 1 commit intomasterfrom
DanielJette merged 1 commit intomasterfrom
Conversation
DanielJette
force-pushed
the
206-generate-diffs
branch
3 times, most recently
from
7ca15e2 to
0100844
Compare
jaredh
approved these changes
Mar 24, 2021
DanielJette
force-pushed
the
206-generate-diffs
branch
from
0100844 to
7d2bd2e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change accomplish?
Resolves #206
How have you achieved it?
Added
TestifyFeatures.GenerateDiffs. When enabled, will output a.diff.pngalongside existing baseline images. These images are high-contrast images where each difference, regardless of how minor, are indicated in red against a black background. See thegenerateDiffstest inScreenshotRuleExampleTestsfor an example. Diff images will be pulled from the device when runningscreenshotPull.Tophat instructions
See the
generateDiffstest inScreenshotRuleExampleTestsfor an example.Notice
This change must keep
masterin a shippable state; it may be shipped without further notice.