This repository was archived by the owner on Aug 8, 2022. It is now read-only.
Fix bug in diff generator#218
Merged
DanielJette merged 3 commits intomasterfrom May 16, 2021
Merged
Conversation
jaredh
approved these changes
May 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change accomplish?
Resolves #215
I noticed a bug where the parallel processor was writing pixels to effectively random locations.
How have you achieved it?
Use
putwith index for parallel pixel processor transform function. The existing code only worked for sequential (single-core) operations. We must store the transformed pixel in the right location using theputmethod that takes a destinationindex. The other version just writes the values sequentially.Tophat instructions
Notice
This change must keep
masterin a shippable state; it may be shipped without further notice.