Skip to content

Conversation

@bmansoob
Copy link
Contributor

@bmansoob bmansoob commented Aug 16, 2022

Forward fix for the comment here: #59 (comment). Thanks, Rafael.

@dalehamel
Copy link
Member

FYI when i did a minimal test it looks like we also need to explicitly require json @bmansoob

@bmansoob
Copy link
Contributor Author

FYI when i did a minimal test it looks like we also need to explicitly require json @bmansoob

thanks -- added.

@rafaelfranca
Copy link
Member

Thanks!

@bmansoob bmansoob merged commit 544972e into main Aug 16, 2022
@bmansoob bmansoob deleted the selective-require branch August 16, 2022 21:02
@shopify-shipit shopify-shipit bot temporarily deployed to production September 23, 2022 18:56 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants