Skip to content
This repository was archived by the owner on Feb 28, 2025. It is now read-only.

Conversation

@QuintonC
Copy link
Collaborator

@QuintonC QuintonC commented May 17, 2023

ℹ️ What is the context for these changes?

Addresses misuse of document.body inside of the Popover component. This was causing errors in some frameworks (such as Remix) where document is undefined.

🕹️ Demonstration

Before After
image image

🎩 How can this be tophatted?

You can pull this branch and run the Next.js or Remix example and it should work as expected, but I've also tested in a SSR context with Hydrogen (the after image in the table above) 👀

✅ Checklist

  • Tested on mobile
  • Tested on multiple browsers
  • Tested for accessibility N/A
  • Includes unit tests N/A
  • Updated relevant documentation for the changes (if necessary) N/A

@QuintonC
Copy link
Collaborator Author

/snapit

@github-actions
Copy link
Contributor

🫰✨ Thanks @QuintonC! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @shopify/blockchain-components@0.0.0-snapshot-20230517182953
yarn add @shopify/connect-wallet@0.0.0-snapshot-20230517182953
yarn add @shopify/gate-context-client@0.0.0-snapshot-20230517182953
yarn add @shopify/tokengate@0.0.0-snapshot-20230517182953

@QuintonC QuintonC marked this pull request as ready for review May 17, 2023 18:36
@QuintonC QuintonC merged commit 35cafb1 into main May 17, 2023
@QuintonC QuintonC deleted the bugfix/address-misuse-of-document-body branch May 17, 2023 18:58
@github-actions github-actions bot mentioned this pull request May 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants