This repository was archived by the owner on Feb 28, 2025. It is now read-only.
🐛 Fixes misuse of document.body in Popover component #191
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ℹ️ What is the context for these changes?
Addresses misuse of
document.bodyinside of thePopovercomponent. This was causing errors in some frameworks (such as Remix) wheredocumentis undefined.🕹️ Demonstration
🎩 How can this be tophatted?
You can pull this branch and run the Next.js or Remix example and it should work as expected, but I've also tested in a SSR context with Hydrogen (the after image in the table above) 👀
✅ Checklist
Tested for accessibilityN/AIncludes unit testsN/AUpdated relevant documentation for the changes (if necessary)N/A