This repository was archived by the owner on Feb 28, 2025. It is now read-only.
🐛 Fixes modal state after connection event #199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuintonC
requested review from
Soleone,
c-bacon and
caropinzonsilva
as code owners
QuintonC
force-pushed
the
bugfix/cleanup-modal-state-on-connect
branch
from
ac649f9 to
74ec3db
Compare
Soleone
approved these changes
Jun 6, 2023
Member
Soleone
left a comment
Soleone
left a comment
There was a problem hiding this comment.
Tophatted and confirmed that before this update the connector gets stuck and after this update the issue is properly fixed.
Code looks good!
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ℹ️ What is the context for these changes?
Fixes a bug where after connecting, the modal state is not reset to the clean state meaning that any subsequent attempts (within the same page load) to reconnect would show the connecting state in the modal.
🕹️ Demonstration
Before
Screen.Recording.2023-06-05.at.6.41.41.PM.mov
After
Screen.Recording.2023-06-05.at.6.37.42.PM.mov
🎩 How can this be tophatted?
yarn dev)✅ Checklist
Tested on mobileN/ATested on multiple browsersN/ATested for accessibilityN/AUpdated relevant documentation for the changes (if necessary)N/A