Pin unicode-segmentation <1.13 (v1.13+ requires Rust 1.86+)#98
Merged
swalkinshaw merged 1 commit intomainfrom Mar 25, 2026
Merged
Pin unicode-segmentation <1.13 (v1.13+ requires Rust 1.86+)#98swalkinshaw merged 1 commit intomainfrom
swalkinshaw merged 1 commit intomainfrom
Conversation
Contributor
Author
|
Oh it's transitive 🤔 |
unicode-segmentation v1.13+ requires Rust 1.86+ (unstable unsigned_is_multiple_of). Pin via direct dep in bluejay-typegen-codegen and commit Cargo.lock so CI uses the pinned version. Remove once Rust toolchain is upgraded to >= 1.86.
swalkinshaw
force-pushed
the
fix-ci-pin-unicode-segmentation
branch
from
dcb440a to
f2f8b39
Compare
Contributor
Author
|
@adampetro are you opposed to committing lock file? It's not recommended against anymore: https://blog.rust-lang.org/2023/08/29/committing-lockfiles/ We could upgrade Rust to fix this but it could easily happen again |
adampetro
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a broken dependency on main due to Rust version. This commits the
Cargo.lockfile to lock the dependency.