feat(react-native): use local android/swift project references#115
Open
kieran-osgood-shopify wants to merge 1 commit into
Open
Conversation
11 tasks
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
11 tasks
React Native — Coverage Report
|
kieran-osgood-shopify
force-pushed
the
kieran-osgood/05-14-featreact-nativeuselocalandroid/swiftprojectreferences
branch
from
06f977e to
9863b61
Compare
kieran-osgood-shopify
changed the base branch from
kieran-osgood/05-14-featprotocoladdtypescriptinterfaces
to
graphite-base/115
kieran-osgood-shopify
force-pushed
the
graphite-base/115
branch
from
5ac9a6d to
cacf47e
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/05-14-featreact-nativeuselocalandroid/swiftprojectreferences
branch
from
9863b61 to
f84aa0f
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/05-14-featreact-nativeuselocalandroid/swiftprojectreferences
branch
2 times, most recently
from
8f6af8c to
9d68bbe
Compare
|
|
||
| def useLocalSdk = (System.getenv("USE_LOCAL_SDK") ?: "0") == "1" | ||
| def shopifySdkArtifact = useLocalSdk | ||
| ? "com.shopify:checkout-kit:1.0.0" |
Contributor
Author
There was a problem hiding this comment.
this version doesn't matter as its just using local so it accepts anything
kieran-osgood-shopify
force-pushed
the
kieran-osgood/05-14-featreact-nativeuselocalandroid/swiftprojectreferences
branch
from
9d68bbe to
193682d
Compare
11 tasks
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you making?
Adds a
--localflag to the react native ios and android commandsUsage:
dev rn android --localdev rn ios --localThis will configure the native code to point to the local
platforms/ios/ andplatforms/android` directory, instead of the published maven and cocoapods versions.This enables a local development feedback loop without waiting for publishes for react native.
How to test
Before you merge
Important
platforms/swift/README.mdand/orplatforms/android/README.md)Releasing a new Swift version?
ShopifyCheckoutKit.podspecplatforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swiftplatforms/swift/CHANGELOG.mdplatforms/swift/README.md(major version only)Releasing a new Android version?
versionNameinplatforms/android/lib/build.gradleplatforms/android/CHANGELOG.mdplatforms/android/README.mdTip
See the Contributing documentation for the full release process per platform.