parse all error messages#152
Merged
Merged
Conversation
kiftio
force-pushed
the
05-19-parse_all_error_messages
branch
from
60bf0d1 to
f0930b1
Compare
kiftio
force-pushed
the
05-19-parse_all_error_messages
branch
from
f0930b1 to
46190cc
Compare
kieran-osgood-shopify
requested changes
May 20, 2026
| * an optional [continueUrl] for buyer handoff or session recovery. | ||
| */ | ||
| @Serializable | ||
| public data class CheckoutErrorResponse internal constructor( |
Contributor
There was a problem hiding this comment.
Can this be replaced with ErrorResponse from Models.kt?
kiftio
force-pushed
the
05-19-parse_all_error_messages
branch
from
46190cc to
0e821b5
Compare
React Native — Coverage Report
|
kiftio
force-pushed
the
05-19-parse_all_error_messages
branch
from
0e821b5 to
587d706
Compare
kieran-osgood-shopify
approved these changes
May 20, 2026
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you making?
This should help bring parity with swift
The
ec.errornotification handler previously decoded only the first error message from themessagesarray and exposed it directly as aCheckoutError. This change introduces a newCheckoutErrorResponsewrapper type that mirrors the full UCPec.errorparams shape, containing:messageslist ofCheckoutErrorobjects, allowing consumers to handle multiple errors rather than assuming a single message.continueUrlfield for buyer handoff or session recovery.The
CheckoutProtocol.errordescriptor now decodes the entire params object into aCheckoutErrorResponseinstead of extracting and decoding only the first element of themessagesarray.How to test
ec.errorpayload.CheckoutProtocol.errorand verify that all messages in themessageslist are accessible, along with thecontinueUrlif present.CheckoutProtocolTestcovers decoding of multiple messages and thecontinueUrlfield.Before you merge
Important
platforms/swift/README.mdand/orplatforms/android/README.md)Releasing a new Swift version?
ShopifyCheckoutKit.podspecplatforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swiftplatforms/swift/CHANGELOG.mdplatforms/swift/README.md(major version only)Releasing a new Android version?
versionNameinplatforms/android/lib/build.gradleplatforms/android/CHANGELOG.mdplatforms/android/README.mdTip
See the Contributing documentation for the full release process per platform.