Widen workspace filters for react-native CI runs#154
Merged
kieran-osgood-shopify merged 1 commit intoMay 19, 2026
Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
React Native — Coverage Report
|
Web — Coverage Report
|
kieran-osgood-shopify
changed the title
kiftio
approved these changes
May 19, 2026
kieran-osgood-shopify
force-pushed
the
kieran-osgood/05-19-fixreactnativeworkflowsrunafterswift/androidchanges
branch
from
b7e3aa2 to
eb91aae
Compare
kieran-osgood-shopify
changed the base branch from
graphite-base/154
to
kieran-osgood/05-19-fixrnandroidbridgechecklistenerrename
11 tasks
graphite-app
Bot
changed the base branch from
kieran-osgood/05-19-fixrnandroidbridgechecklistenerrename
to
main
Merge activity
|
toneymathews
approved these changes
May 19, 2026
Contributor
toneymathews
left a comment
toneymathews
left a comment
There was a problem hiding this comment.
lgtm. You mentioned in the call I think - but how would Android / Swift changes break CI for RN? I thought each platform's changes would be independent of others.
Contributor
Author
|
@toneymathews The React Native SDK's mostly proxy behaviour to the Swift / Android SDK's, behaving primarily as a bridge between JS and the Native runtimes Lets say we want to change the user agent, we'd first fix it in swift/kotlin (two sdk edits), release those under a semver release (two separate releases), then react-native can point to the new release in its dependency list and includes the fix, meaning we effectively write the user agent twice, but release it under 3 platforms |
Contributor
|
TY for explaining this, TIL:+1: |
kieran-osgood-shopify
force-pushed
the
kieran-osgood/05-19-fixreactnativeworkflowsrunafterswift/androidchanges
branch
from
eb91aae to
acc7eee
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/05-19-fixreactnativeworkflowsrunafterswift/androidchanges
branch
from
acc7eee to
ee35b53
Compare
kieran-osgood-shopify
deleted the
kieran-osgood/05-19-fixreactnativeworkflowsrunafterswift/androidchanges
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you making?
Not running react-native when swift/android changes are detected results in false positive CI runs and broken CI on main
How to test
Before you merge
Important
platforms/swift/README.mdand/orplatforms/android/README.md)Releasing a new Swift version?
ShopifyCheckoutKit.podspecplatforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swiftplatforms/swift/CHANGELOG.mdplatforms/swift/README.md(major version only)Releasing a new Android version?
versionNameinplatforms/android/lib/build.gradleplatforms/android/CHANGELOG.mdplatforms/android/README.mdTip
See the Contributing documentation for the full release process per platform.