Skip to content

chore: pin quicktype from pnpm#204

Open
westeezy wants to merge 1 commit into
05-25-schema_provinencefrom
05-25-cleanup_quicktype_scripts
Open

chore: pin quicktype from pnpm#204
westeezy wants to merge 1 commit into
05-25-schema_provinencefrom
05-25-cleanup_quicktype_scripts

Conversation

@westeezy
Copy link
Copy Markdown
Contributor

@westeezy westeezy commented May 25, 2026

What changes are you making?

Update quicktype to download from npm so we can pin a version safely and rely on that version. brew only serves latest

How to test


Before you merge

Important

  • I've added tests to support my implementation
  • I have read and agree with the Contribution Guidelines
  • I have read and agree with the Code of Conduct
  • I've updated the relevant platform README (platforms/swift/README.md and/or platforms/android/README.md)

Releasing a new Swift version?
  • I have bumped the version in ShopifyCheckoutKit.podspec
  • I have bumped the version in platforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swift
  • I have updated platforms/swift/CHANGELOG.md
  • I have updated the SwiftPM/CocoaPods version snippets in platforms/swift/README.md (major version only)
Releasing a new Android version?
  • I have bumped the versionName in platforms/android/lib/build.gradle
  • I have updated platforms/android/CHANGELOG.md
  • I have updated the Gradle/Maven version snippets in platforms/android/README.md

Tip

See the Contributing documentation for the full release process per platform.

Copy link
Copy Markdown
Contributor Author

westeezy commented May 25, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 25, 2026

React Native — Coverage Report

Lines Statements Branches Functions
Coverage: 98%
96.76% (239/247) 91.02% (142/156) 100% (64/64)

@westeezy westeezy changed the base branch from 05-25-regenerate_models to graphite-base/204 May 25, 2026 22:28
@westeezy westeezy force-pushed the 05-25-cleanup_quicktype_scripts branch from dc3a9a8 to 38101a6 Compare May 25, 2026 22:29
@westeezy westeezy force-pushed the graphite-base/204 branch from 9338dfe to 29dd3d2 Compare May 25, 2026 22:29
@westeezy westeezy changed the base branch from graphite-base/204 to 05-25-schema_update_scripts May 25, 2026 22:29
@westeezy westeezy marked this pull request as ready for review May 25, 2026 23:11
@westeezy westeezy requested a review from a team as a code owner May 25, 2026 23:11
@westeezy westeezy force-pushed the 05-25-cleanup_quicktype_scripts branch from 38101a6 to cf2e2d0 Compare May 25, 2026 23:34
@westeezy westeezy force-pushed the 05-25-schema_update_scripts branch from 29dd3d2 to 67ff7da Compare May 25, 2026 23:34
Pin quicktype as a protocol-local pnpm dependency and update protocol codegen to use that binary instead of a globally installed package.
@westeezy westeezy force-pushed the 05-25-schema_update_scripts branch from 67ff7da to f6df98b Compare May 26, 2026 00:15
@westeezy westeezy force-pushed the 05-25-cleanup_quicktype_scripts branch from cf2e2d0 to 63c1451 Compare May 26, 2026 00:15
@westeezy westeezy changed the base branch from 05-25-schema_update_scripts to graphite-base/204 May 26, 2026 00:39
@westeezy westeezy changed the base branch from graphite-base/204 to 05-25-schema_provinence May 26, 2026 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant