Merged
Conversation
jamieguerrero
approved these changes
Jan 15, 2025
Contributor
jamieguerrero
left a comment
jamieguerrero
left a comment
There was a problem hiding this comment.
Tophatted and LGTM!
Contributor
Coverage report
Show files with reduced coverage 🔻
Test suite run success2003 tests passing in 905 suites. Report generated by 🧪jest coverage report action from 3693514 |
amcaplan
force-pushed
the
no-color-fix
branch
2 times, most recently
from
ed0047f to
2793fa7
Compare
graygilmore
approved these changes
Jan 16, 2025
Contributor
graygilmore
left a comment
graygilmore
left a comment
There was a problem hiding this comment.
Other than the eslint errors that need fixing this looks good!
Certain versions of node add colors to console.warn and console.error which doesn't respect our control of colors via chalk. To avoid this kind of interference with the CLI, we should write directly to output streams.
amcaplan
force-pushed
the
no-color-fix
branch
from
2793fa7 to
3693514
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
The user's expressed
--no-colorpreference is not respected when logging warnings and errors.Additional context: Some versions of node color
console.warnoutput yellow andconsole.erroroutput red unless they output is already colored explicitly. While this has been rolled back, it seems safest to stop relying on these functions and simply write directly to stdout/stderr.WHAT is this pull request doing?
$ p shopify kitchen-sink static --no-colorBefore:
After:
How to test your changes?
$ p shopify kitchen-sink staticwith and without--no-colorPost-release steps
Measuring impact
How do we know this change was effective? Please choose one:
Checklist