-
Notifications
You must be signed in to change notification settings - Fork 224
Update preview URL based on dev session status #5272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update preview URL based on dev session status #5272
Conversation
|
We detected some changes at packages/*/src and there are no updates in the .changeset. |
218c502 to
a7bf159
Compare
|
/snapit |
|
🫰✨ Thanks @isaacroldan! Your snapshot has been published to npm. Test the snapshot by intalling your package globally: pnpm i -g @shopify/cli@0.0.0-snapshot-20250127111920
|
Coverage report
Show files with reduced coverage 🔻
Test suite run success2012 tests passing in 905 suites. Report generated by 🧪jest coverage report action from 9301fe3 |
a7bf159 to
6001250
Compare
6001250 to
9301fe3
Compare

WHY are these changes introduced?
For dev-sessions, update the preview URL dynamically depending on whether the app has previewable extensions or not.
WHAT is this pull request doing?
devSessionPreviewURLstate to track and update the preview URLHow to test your changes?
Start a dev session with no previewable extensions (no UI ext.)
Add a previewable extension (admin-action for example)
Remove all previewable extensions
Measuring impact
Checklist