Drive DCDD from server specifications

[shauns]

Closes https://github.com/Shopify/develop-app-storage/issues/18

WHY are these changes introduced?

Removes the custom data specification and improves handling of remote extension specifications with different UID strategies. As DCDD is an app.toml managed module, we need to be able to indicate that it's UID strategy is single

WHAT is this pull request doing?

• Removes the custom data specification and its associated configuration
• Updates the UID strategy handling based on uidIsClientProvided flag

How to test your changes?

1. Run the test suite to verify the updated remote specification handling
2. Tophat: make an app, connect to DL org (has module enabled), all the following should work.

• Run dev, add [metaobjects.author.fields]\nbirthday="date" , no failure
• Deploy same config, no failure
• Do a link into a new file, see the above config preserved

Measuring impact

• n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix

Checklist

• I've considered possible cross-platform impacts (Mac, Linux, Windows)
• I've considered possible documentation changes

[shauns]

• Drive DCDD from server specifications #5276 👈 (View in Graphite)
• JSON schema parsing strips extra properties #5275
• RemoteSpecfication includes uidIsClientProvided #5274
• App management schemas are found on the main branch #5273
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

Coverage report

St.❔	Category	Percentage	Covered / Total
🟡	Statements	75.42% (+0.02% 🔼)	8960/11880
🟡	Branches	70.54% (-0.08% 🔻)	4358/6178
🟡	Functions	75.24% (+0.06% 🔼)	2349/3122
🟡	Lines	75.94% (-0.01% 🔻)	8465/11147

Show new covered files 🐣

St.❔	File	Statements	Branches	Functions	Lines
🟢	... / theme_files_delete.ts	100%	100%	100%	100%

Show files with reduced coverage 🔻

St.❔	File	Statements	Branches	Functions	Lines
🟢	... / store-context.ts	100%	78.57% (-21.43% 🔻)	100%	100%
🔴	... / extension.ts	51.43% (-3.12% 🔻)	0%	60%	54.55% (-1.7% 🔻)
🟢	... / payload.ts	95.45%	75% (-13.89% 🔻)	100%	100%
🟢	... / previewable-extension.ts	85.71% (-3.17% 🔻)	100%	66.67%	83.33% (-4.17% 🔻)
🟢	... / setup-dev-processes.ts	95.56% (+0.1% 🔼)	78.57% (-3.57% 🔻)	90.91%	94.87% (+0.13% 🔼)
🟢	... / json-schema.ts	93.55% (-0.07% 🔻)	86.05%	100%	93.48% (-0.07% 🔻)
🔴	... / api.ts	53.97% (-3.84% 🔻)	39.77% (-3.98% 🔻)	53.49% (-5.05% 🔻)	54.75% (-4.4% 🔻)

Test suite run success

2015 tests passing in 905 suites.

Report generated by 🧪jest coverage report action from 7be6815

[github-actions]

We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run "pnpm changeset add" to track your changes and include them in the next release CHANGELOG.

[isaacroldan]

🎩 and 👌

[github-actions]

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

• Some seemingly private modules might be re-exported through public modules.
• If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/public/node/json-schema.d.ts

@@ -1,5 +1,6 @@
 import { ParseConfigurationResult } from './schema.js';
 import { ErrorObject, SchemaObject } from 'ajv';
+export type HandleInvalidAdditionalProperties = 'strip' | 'fail';
 type AjvError = ErrorObject<string, {
     [key: string]: unknown;
 }>;
@@ -19,10 +20,11 @@ export declare function normaliseJsonSchema(schema: string): Promise<SchemaObjec
  *
  * @param subject - The object to validate.
  * @param schema - The JSON schema to validate against.
+ * @param handleInvalidAdditionalProperties - Whether to strip or fail on invalid additional properties.
  * @param identifier - The identifier of the schema being validated, used to cache the validator.
  * @returns The result of the validation. If the state is 'error', the errors will be in a zod-like format.
  */
-export declare function jsonSchemaValidate(subject: object, schema: SchemaObject, identifier: string): ParseConfigurationResult<unknown> & {
+export declare function jsonSchemaValidate(subject: object, schema: SchemaObject, handleInvalidAdditionalProperties: HandleInvalidAdditionalProperties, identifier?: string): ParseConfigurationResult<unknown> & {
     rawErrors?: AjvError[];
 };
 export {};
\ No newline at end of file