Remove opt-out for improve config module loading #5818
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 16, 2025
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/archiver.d.ts@@ -20,43 +20,4 @@ interface ZipOptions {
* @param options - ZipOptions.
*/
export declare function zip(options: ZipOptions): Promise<void>;
-export interface BrotliOptions {
- /**
- * The directory to compress.
- */
- inputDirectory: string;
- /**
- * The path where the compressed file will be saved.
- */
- outputPath: string;
- /**
- * An optional glob pattern to match files.
- */
- matchFilePattern?: string | string[];
- /**
- * Brotli compression level (0-11, default: 11).
- */
- level?: number;
-}
-/**
- * Options for decompressing a Brotli compressed tar archive.
- */
-export interface DecompressionOptions {
- /**
- * Path to the compressed file.
- */
- inputFile: string;
- /**
- * Directory where files should be extracted.
- */
- outputDirectory: string;
-}
-/**
- * It compresses a directory with Brotli.
- * First creates a tar archive to preserve directory structure,
- * then compresses it with Brotli.
- *
- * @param options - BrotliOptions.
- */
-export declare function brotliCompress(options: BrotliOptions): Promise<void>;
export {};
\ No newline at end of file
packages/cli-kit/dist/public/node/fs.d.ts@@ -323,10 +323,4 @@ export interface MatchGlobOptions {
* @returns true if the key matches the pattern, false otherwise.
*/
export declare function matchGlob(key: string, pattern: string, options?: MatchGlobOptions): boolean;
-/**
- * Read a directory.
- * @param path - The path to read.
- * @returns A promise that resolves to an array of file names.
- */
-export declare function readdir(path: string): Promise<string[]>;
export {};
\ No newline at end of file
packages/cli-kit/dist/public/node/git.d.ts@@ -129,11 +129,4 @@ export declare function ensureIsClean(directory?: string): Promise<void>;
* @param directory - The directory to check.
* @returns True is the .git directory is clean.
*/
-export declare function isClean(directory?: string): Promise<boolean>;
-/**
- * Returns the latest tag of a git repository.
- *
- * @param directory - The directory to check.
- * @returns String with the latest tag or undefined if no tags are found.
- */
-export declare function getLatestTag(directory?: string): Promise<string | undefined>;
\ No newline at end of file
+export declare function isClean(directory?: string): Promise<boolean>;
\ No newline at end of file
|
Contributor
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success2911 tests passing in 1261 suites. Report generated by 🧪jest coverage report action from e66b6e3 |
Contributor
gonzaloriestra
left a comment
gonzaloriestra
left a comment
There was a problem hiding this comment.
Ok, now I'm totally confused 😂
Why adding two flags and then removing them in two consecutive PRs? What's the plan?
shauns
force-pushed
the
shauns/05-16-remove_opt-out_for_improve_config_module_loading
branch
from
519731c to
d9b7e60
Compare
shauns
force-pushed
the
shauns/05-16-use_improved_config_module_loading_by_default
branch
from
52d1b32 to
2687ba6
Compare
Contributor
|
This PR seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. |
isaacroldan
approved these changes
Jun 20, 2025
Contributor
|
I guess the plan is to release the previous PR and then wait 1-2 releases before merging this one :) |
shauns
force-pushed
the
shauns/05-16-use_improved_config_module_loading_by_default
branch
from
2687ba6 to
d691457
Compare
shauns
force-pushed
the
shauns/05-16-remove_opt-out_for_improve_config_module_loading
branch
from
d9b7e60 to
e66b6e3
Compare
Contributor
Author
|
That's right - let 5817 ship and then this can follow up in a subsequent release. This is the PR that fully migrates and removes The Old Way. |
Base automatically changed from
shauns/05-16-use_improved_config_module_loading_by_default
to
main
June 25, 2025 10:39
Contributor
|
According to this plan, we can now merge this. |
Contributor
Author
|
Yes 👍 |
gonzaloriestra
deleted the
shauns/05-16-remove_opt-out_for_improve_config_module_loading
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
To improve validation of app configuration files by enforcing stricter checks on unsupported sections in app.toml files. See #5816
Removes the
SHOPIFY_CLI_DISABLE_UNSUPPORTED_CONFIG_PROPERTY_CHECKSopt-out.