Skip to content

Conversation

@isaacroldan
Copy link
Contributor

@isaacroldan isaacroldan commented Aug 19, 2025

WHY are these changes introduced?

Fixes an issue where webhook subscriptions were incorrectly blocking the dev command due to missing UIDs.

WHAT is this pull request doing?

Modifies the blockIfMigrationIncomplete function to ignore webhook subscriptions when checking if extensions have assigned UIDs. Webhook subscriptions do need UIDs but shouldn't block the dev command from proceeding.

How to test your changes?

  1. Create an app with webhook subscriptions
  2. Run the dev command
  3. Verify that the dev command doesn't block due to webhook subscriptions missing UIDs

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentationchanges

Copy link
Contributor Author

isaacroldan commented Aug 19, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@isaacroldan isaacroldan force-pushed the 08-19-webhook_subscriptions_shouldnt_block_dev branch from 1ed4170 to 716cb5c Compare August 19, 2025 16:35
@isaacroldan isaacroldan marked this pull request as ready for review August 19, 2025 16:35
@isaacroldan isaacroldan requested a review from a team as a code owner August 19, 2025 16:35
@github-actions
Copy link
Contributor

We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run pnpm changeset add to track your changes and include them in the next release CHANGELOG.

Caution

DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 19, 2025

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
78.42% (+0% 🔼)
13319/16985
🟡 Branches 72.43% 6510/8988
🟡 Functions
78.58% (+0% 🔼)
3464/4408
🟡 Lines
78.78% (+0% 🔼)
12598/15992

Test suite run success

3160 tests passing in 1330 suites.

Report generated by 🧪jest coverage report action from 42ad5af

const extensions = (await developerPlatformClient.appExtensionRegistrations(remoteApp)).app.extensionRegistrations
if (!extensions.every((extension) => extension.id)) {
if (
!extensions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just want to confirm we can remove this code later right? (since this is a new "Consistency violation" we should have a plan for end-of-life)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this whole function will be removed as part of the migration cleaning, it was only added to show a temporary banner

Copy link
Contributor

@pt2pham pt2pham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to Mitch that we need to note this down as tech debt to remove

@isaacroldan isaacroldan force-pushed the 08-19-change_how_webhook_subscription_uid_is_generated branch from a1c1181 to c07b233 Compare August 20, 2025 07:49
@isaacroldan isaacroldan force-pushed the 08-19-webhook_subscriptions_shouldnt_block_dev branch from 716cb5c to 42ad5af Compare August 20, 2025 07:49
@github-actions
Copy link
Contributor

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/public/node/monorail.d.ts
@@ -112,10 +112,6 @@ export interface Schemas {
             app_web_framework?: Optional<string>;
             app_web_frontend_any?: Optional<boolean>;
             app_web_frontend_count?: Optional<number>;
-            cmd_theme_timings?: Optional<string>;
-            cmd_theme_errors?: Optional<string>;
-            cmd_theme_retries?: Optional<string>;
-            cmd_theme_events?: Optional<string>;
             env_ci?: Optional<boolean>;
             env_ci_platform?: Optional<string>;
             env_device_id?: Optional<string>;

Base automatically changed from 08-19-change_how_webhook_subscription_uid_is_generated to main August 20, 2025 08:01
@isaacroldan isaacroldan added this pull request to the merge queue Aug 20, 2025
Merged via the queue into main with commit b80e57f Aug 20, 2025
1 check passed
@isaacroldan isaacroldan deleted the 08-19-webhook_subscriptions_shouldnt_block_dev branch August 20, 2025 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants