No longer raise password errors when users use custom app passwords on shopify theme pull/push commands
#6319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n `shopify theme pull/push` commands
Contributor
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success3233 tests passing in 1354 suites. Report generated by 🧪jest coverage report action from 87bedd2 |
aswamy
approved these changes
Aug 26, 2025
| noCacheDefault: true, | ||
| }), | ||
| password: Flags.string({ | ||
| description: 'Password generated from the Theme Access app.', |
Contributor
There was a problem hiding this comment.
I don't know if you want this documented or not, but should we write it here so we don't get reports of --password flag being inconsistent?
Suggested change
| description: 'Password generated from the Theme Access app.', | |
| description: 'Password generated from the Theme Access app. Legacy: Supports custom app passwords for `push` and `pull` commands.', |
Contributor
There was a problem hiding this comment.
Spoke about it - we will keep the description as is
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
5 tasks
EvilGenius13
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
We no longer raise password errors when users use custom app passwords with the
shopify theme pullorpushcommands.WHAT is this pull request doing?
This change moves logic from
packages/theme/src/cli/flags.tsto the specific commands that do not support custom app password authentication. The legacy method is only supported on certain commands.How to test your changes?
shopify theme dev --password <custom_app_password>shopify theme push --password <custom_app_password>Post-release steps
N/A
Measuring impact
How will we know this change was effective? Please choose one:
Checklist