Conversation
Contributor
|
We detected some changes at Caution DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release. |
Contributor
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success3715 tests passing in 1438 suites. Report generated by 🧪jest coverage report action from ce04cc6 |
alfonso-noriega
approved these changes
Dec 19, 2025
Contributor
|
This PR seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. |
86748ac to
ce04cc6
Compare
dmerand
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Related to https://github.com/shop/issues-bundles-and-combined-listings/issues/1250
When running
app devagainst local, the App Home link points tohttps://dev-store-local.my.shop.dev/admin/oauth/redirect_from_cli?client_id=xxx, which throws a 404:Related discussion: https://shopify.slack.com/archives/C08GKEEKXGE/p1765883873388589
WHAT is this pull request doing?
Replaces
.my.shop.devwith.dev-api.shop.dev, which is apparently required for the OAuth flow: https://github.com/Shopify/dev_server?tab=readme-ov-file#shop-redirectsHow to test your changes?
SHOPIFY_CLI_NEVER_USE_PARTNERS_API=1 SHOPIFY_SERVICE_ENV=local pnpm shopify app devMeasuring impact
How do we know this change was effective? Please choose one:
Checklist