Skip to content

Script to create notification PR#7004

Merged
gonzaloriestra merged 1 commit into
mainfrom
release-notification
Mar 13, 2026
Merged

Script to create notification PR#7004
gonzaloriestra merged 1 commit into
mainfrom
release-notification

Conversation

@gonzaloriestra
Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

The post-release step to create a PR adding a notification is a bit tedious

WHAT is this pull request doing?

Adds a script to automate that step, creating a PR with a template to only update the content.

Once it's merged, I'll update the release instructions.

Example of generated PR: https://github.com/Shopify/static-cdn-assets/pull/1894

How to test your changes?

bin/create-notification-pr.js

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

@gonzaloriestra gonzaloriestra requested a review from a team as a code owner March 13, 2026 13:44
@github-actions
Copy link
Copy Markdown
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 77.24% 14568/18860
🟡 Branches 70.89% 7229/10198
🟡 Functions 76.21% 3701/4856
🟡 Lines 78.73% 13770/17490

Test suite run success

3806 tests passing in 1462 suites.

Report generated by 🧪jest coverage report action from c9c6023

@gonzaloriestra gonzaloriestra added this pull request to the merge queue Mar 13, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Mar 13, 2026
Copy link
Copy Markdown
Contributor Author

I've updated the instructions here: https://github.com/Shopify/develop-app-inner-loop/issues/2694

@gonzaloriestra gonzaloriestra added this pull request to the merge queue Mar 13, 2026
Merged via the queue into main with commit cb49b63 Mar 13, 2026
25 checks passed
@gonzaloriestra gonzaloriestra deleted the release-notification branch March 13, 2026 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants