Smaller bundle by gonzaloriestra · Pull Request #7013 · Shopify/cli

gonzaloriestra · 2026-03-13T16:20:29Z

WHY are these changes introduced?

The CLI bundle is larger than necessary.

WHAT is this pull request doing?

Reduces CLI bundle size by ~55% (62 MB → 28 MB)

Enable minifyWhitespace and minifyIdentifiers in esbuild (previously only minifySyntax was on)
Exclude source map files from the npm package via !/dist/**/*.map in files (maps are still generated for Observe)
Replace brotli JS package with native zlib.brotliCompressSync
Simplify entry points instead of globbing all .ts files

How to test your changes?

pnpm bundle-for-release and check dist folder
npm i -g --@shopify:registry=https://registry.npmjs.org @0.0.0-snapshot-20260318104923
shopify app deploy (exercises brotli compression)

Measuring impact

How do we know this change was effective? Please choose one:

n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
Existing analytics will cater for this addition
PR includes analytics changes to measure impact

Checklist

I've considered possible cross-platform impacts (Mac, Linux, Windows)
I've considered possible documentation changes

gonzaloriestra · 2026-03-13T16:26:22Z

/snapit

github-actions · 2026-03-13T16:27:31Z

Coverage report

St.^❔	Category	Percentage	Covered / Total
🟢	Statements	82.17%	14929/18169
🟡	Branches	74.52%	7375/9897
🟢	Functions	81.29%	3776/4645
🟢	Lines	82.55%	14116/17099

Test suite run success

3933 tests passing in 1514 suites.

Report generated by 🧪jest coverage report action from 8fa1647

gonzaloriestra · 2026-03-13T17:10:16Z

/snapit

github-actions · 2026-03-13T17:12:38Z

🫰✨ Thanks @gonzaloriestra! Your snapshot has been published to npm.

Test the snapshot by installing your package globally:

npm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20260313171105

Caution

After installing, validate the version by running shopify version in your terminal.
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.

gonzaloriestra · 2026-03-17T16:05:35Z

/snapit

github-actions · 2026-03-17T16:08:44Z

🫰✨ Thanks @gonzaloriestra! Your snapshot has been published to npm.

Test the snapshot by installing your package globally:

npm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20260317160706

Caution

After installing, validate the version by running shopify version in your terminal.
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.

gonzaloriestra · 2026-03-18T10:48:37Z

/snapit

github-actions · 2026-03-18T10:51:05Z

🫰✨ Thanks @gonzaloriestra! Your snapshot has been published to npm.

Test the snapshot by installing your package globally:

npm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20260318104923

Caution

After installing, validate the version by running shopify version in your terminal.
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.

github-actions · 2026-03-18T14:38:49Z

We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run pnpm changeset add to track your changes and include them in the next release CHANGELOG.

Caution

DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release.

craigmichaelmartin

So cool! Thank you for leading these autoresearch improvements!!

dmerand

I love this approach overall! Review found a couple of concerns worth addressing prior to shipping.

gonzaloriestra · 2026-03-19T11:03:21Z

/snapit

github-actions · 2026-03-19T11:05:51Z

🫰✨ Thanks @gonzaloriestra! Your snapshot has been published to npm.

Test the snapshot by installing your package globally:

npm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20260319110410

Caution

After installing, validate the version by running shopify version in your terminal.
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.

… — saves ~5,904 KB\n\nResult: {"status":"keep","bundle_kb":125332,"js_kb":46412,"maps_kb":74152,"assets_kb":4768}

…784, maps: -2,328)\n\nResult: {"status":"keep","bundle_kb":111220,"js_kb":34628,"maps_kb":71824,"assets_kb":4768}

…ings)\n\nResult: {"status":"keep","bundle_kb":99508,"js_kb":30844,"maps_kb":63896,"assets_kb":4768}

…. Already lazy-loaded via dynamic import.\n\nResult: {"status":"keep","bundle_kb":76368,"js_kb":22848,"maps_kb":48752,"assets_kb":4768}

…ble at runtime as project dep.\n\nResult: {"status":"keep","bundle_kb":57192,"js_kb":16500,"maps_kb":35924,"assets_kb":4768}

…dable (identifiers not minified).\n\nResult: {"status":"keep","bundle_kb":21440,"js_kb":16500,"maps_kb":172,"assets_kb":4768}

…36)\n\nResult: {"status":"keep","bundle_kb":16776,"js_kb":11836,"maps_kb":172,"assets_kb":4768}

…,132 KB\n\nResult: {"status":"keep","bundle_kb":15644,"js_kb":10704,"maps_kb":172,"assets_kb":4768}

…s 524 KB\n\nResult: {"status":"keep","bundle_kb":15120,"js_kb":10180,"maps_kb":172,"assets_kb":4768}

… KB\n\nResult: {"status":"keep","bundle_kb":14128,"js_kb":9188,"maps_kb":172,"assets_kb":4768}

…conciler@0.29.2) — saves 424 KB\n\nResult: {"status":"keep","bundle_kb":13704,"js_kb":8764,"maps_kb":172,"assets_kb":4768}

…ed impact)\n\nResult: {"status":"keep","bundle_kb":13592,"js_kb":8652,"maps_kb":172,"assets_kb":4768}

…Result: {"status":"keep","bundle_kb":13176,"js_kb":8236,"maps_kb":172,"assets_kb":4768}

…-parser, @vscode/web-custom-data — saves 1,136 KB\n\nResult: {"status":"keep","bundle_kb":12040,"js_kb":7100,"maps_kb":172,"assets_kb":4768}

…mver, yaml, js-yaml, execa — saves 1,100 KB\n\nResult: {"status":"keep","bundle_kb":10940,"js_kb":6000,"maps_kb":172,"assets_kb":4768}

…eing bundled) — saves 348 KB\n\nResult: {"status":"keep","bundle_kb":10592,"js_kb":5652,"maps_kb":172,"assets_kb":4768}

… 20+ more runtime deps — saves 1,868 KB\n\nResult: {"status":"keep","bundle_kb":8724,"js_kb":3784,"maps_kb":172,"assets_kb":4768}

Comments already addressed

isaacroldan reviewed Mar 16, 2026

View reviewed changes

Comment thread packages/cli/bin/bundle.js Outdated

isaacroldan reviewed Mar 16, 2026

View reviewed changes

Comment thread packages/cli/bin/bundle.js Outdated

gonzaloriestra force-pushed the smaller-bundle branch 2 times, most recently from 9893f54 to 696e5f7 Compare March 17, 2026 15:10

isaacroldan reviewed Mar 17, 2026

View reviewed changes

Comment thread packages/cli/bin/bundle.js Outdated

Comment thread packages/cli/bin/bundle.js

Comment thread packages/cli/bin/bundle.js Outdated

gonzaloriestra force-pushed the smaller-bundle branch from a573c2d to 195248b Compare March 18, 2026 11:44

gonzaloriestra marked this pull request as ready for review March 18, 2026 14:38

gonzaloriestra requested a review from a team as a code owner March 18, 2026 14:38

craigmichaelmartin approved these changes Mar 18, 2026

View reviewed changes

ryancbahan approved these changes Mar 18, 2026

View reviewed changes

dmerand previously requested changes Mar 18, 2026

View reviewed changes

Comment thread packages/cli/bin/bundle.js Outdated

Comment thread packages/cli/bin/bundle.js

gonzaloriestra requested a review from dmerand March 19, 2026 11:27

gonzaloriestra enabled auto-merge March 20, 2026 15:34

gonzaloriestra added 6 commits March 24, 2026 10:51

autoresearch: setup bundle size optimization

77b7a5d

fix checks script - remove broken lint

b16ec5c

Replace brotli JS package with native Node.js zlib.brotliCompressSync…

10495ee

… — saves ~5,904 KB\n\nResult: {"status":"keep","bundle_kb":125332,"js_kb":46412,"maps_kb":74152,"assets_kb":4768}

Enable minifyWhitespace in esbuild bundle — saves 14,112 KB (JS: -11,…

9029f1d

…784, maps: -2,328)\n\nResult: {"status":"keep","bundle_kb":111220,"js_kb":34628,"maps_kb":71824,"assets_kb":4768}

Externalize prettier from bundle (~4MB input, ~11.7MB output+maps sav…

d0e7e25

…ings)\n\nResult: {"status":"keep","bundle_kb":99508,"js_kb":30844,"maps_kb":63896,"assets_kb":4768}

Externalize ts-morph (+ typescript dep) from bundle — saves 23,140 KB…

f965f67

…. Already lazy-loaded via dynamic import.\n\nResult: {"status":"keep","bundle_kb":76368,"js_kb":22848,"maps_kb":48752,"assets_kb":4768}

gonzaloriestra added 21 commits March 24, 2026 10:51

Externalize typescript compiler from bundle — saves 19,176 KB. Availa…

527ea00

…ble at runtime as project dep.\n\nResult: {"status":"keep","bundle_kb":57192,"js_kb":16500,"maps_kb":35924,"assets_kb":4768}

Disable esbuild source maps — saves 35,752 KB. Stack traces still rea…

3ad1c61

…dable (identifiers not minified).\n\nResult: {"status":"keep","bundle_kb":21440,"js_kb":16500,"maps_kb":172,"assets_kb":4768}

Enable minifyIdentifiers in esbuild — saves 4,664 KB (JS: 16,500→11,8…

8426419

…36)\n\nResult: {"status":"keep","bundle_kb":16776,"js_kb":11836,"maps_kb":172,"assets_kb":4768}

Externalize @shopify/polaris, polaris-icons, polaris-tokens — saves 1…

03ab8dd

…,132 KB\n\nResult: {"status":"keep","bundle_kb":15644,"js_kb":10704,"maps_kb":172,"assets_kb":4768}

Externalize react-dom (only used for GraphiQL SSR, not by ink) — save…

9ccc21b

…s 524 KB\n\nResult: {"status":"keep","bundle_kb":15120,"js_kb":10180,"maps_kb":172,"assets_kb":4768}

Externalize vscode language service packages (~2MB input) — saves 992…

33e21ca

… KB\n\nResult: {"status":"keep","bundle_kb":14128,"js_kb":9188,"maps_kb":172,"assets_kb":4768}

Externalize @oclif/table (avoids bundling ink@5 + react@18 + react-re…

0e00791

…conciler@0.29.2) — saves 424 KB\n\nResult: {"status":"keep","bundle_kb":13704,"js_kb":8764,"maps_kb":172,"assets_kb":4768}

Externalize lodash — saves 112 KB (partial tree-shaking already reduc…

72078af

…ed impact)\n\nResult: {"status":"keep","bundle_kb":13592,"js_kb":8652,"maps_kb":172,"assets_kb":4768}

Externalize @opentelemetry packages (~1.3MB input) — saves 416 KB\n\n…

32bd602

…Result: {"status":"keep","bundle_kb":13176,"js_kb":8236,"maps_kb":172,"assets_kb":4768}

Externalize theme-check/language-server packages, ohm-js, liquid-html…

55a8873

…-parser, @vscode/web-custom-data — saves 1,136 KB\n\nResult: {"status":"keep","bundle_kb":12040,"js_kb":7100,"maps_kb":172,"assets_kb":4768}

Externalize ink, react, react-reconciler, ajv, archiver, liquidjs, se…

326b871

…mver, yaml, js-yaml, execa — saves 1,100 KB\n\nResult: {"status":"keep","bundle_kb":10940,"js_kb":6000,"maps_kb":172,"assets_kb":4768}

Exclude test files from bundle entry points (11 .test.ts files were b…

dfbcbf6

…eing bundled) — saves 348 KB\n\nResult: {"status":"keep","bundle_kb":10592,"js_kb":5652,"maps_kb":172,"assets_kb":4768}

Externalize @oclif/core, graphql, zod, jose, node-fetch, got, ws, and…

f81dec7

… 20+ more runtime deps — saves 1,868 KB\n\nResult: {"status":"keep","bundle_kb":8724,"js_kb":3784,"maps_kb":172,"assets_kb":4768}

Last step

180c34d

Fix bundle issue

152b3fc

Fix lint and knip

e91b684

Remove temp files

32aca52

Only externalize some deps and enable sourcemap

6cd6fd8

Do not externalize required deps

b812f70

Fix entryPoints and switch sourcemap to external

f029543

Update pnpm-lock.yaml

8fa1647

gonzaloriestra force-pushed the smaller-bundle branch from 80da9e0 to 8fa1647 Compare March 24, 2026 09:52

gonzaloriestra added this pull request to the merge queue Mar 24, 2026

Merged via the queue into main with commit 1ab6618 Mar 24, 2026
29 checks passed

gonzaloriestra deleted the smaller-bundle branch March 24, 2026 10:09

gonzaloriestra mentioned this pull request Mar 25, 2026

Fix oclif importing issue in bundle #7097

Merged

5 tasks

Conversation

gonzaloriestra commented Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

WHY are these changes introduced?

WHAT is this pull request doing?

How to test your changes?

Measuring impact

Checklist

Uh oh!

gonzaloriestra commented Mar 13, 2026

Uh oh!

github-actions Bot commented Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage report

Test suite run success

Uh oh!

gonzaloriestra commented Mar 13, 2026

Uh oh!

github-actions Bot commented Mar 13, 2026

Uh oh!

Uh oh!

Uh oh!

gonzaloriestra commented Mar 17, 2026

Uh oh!

github-actions Bot commented Mar 17, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gonzaloriestra commented Mar 18, 2026

Uh oh!

github-actions Bot commented Mar 18, 2026

Uh oh!

github-actions Bot commented Mar 18, 2026

Uh oh!

craigmichaelmartin left a comment

Choose a reason for hiding this comment

Uh oh!

dmerand left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

gonzaloriestra commented Mar 19, 2026

Uh oh!

github-actions Bot commented Mar 19, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

gonzaloriestra commented Mar 13, 2026 •

edited

Loading

github-actions Bot commented Mar 13, 2026 •

edited

Loading