Skip to content

Add admin hoted app local spec#7027

Draft
alfonso-noriega wants to merge 2 commits intoadd_manifest_to_include_files_stepfrom
add_admin_config_local_spec
Draft

Add admin hoted app local spec#7027
alfonso-noriega wants to merge 2 commits intoadd_manifest_to_include_files_stepfrom
add_admin_config_local_spec

Conversation

@alfonso-noriega
Copy link
Contributor

@alfonso-noriega alfonso-noriega commented Mar 17, 2026

WHY are these changes introduced?

The admin extension type was previously hardcoded as a string literal, which prevented proper specification handling and caused inconsistencies in the extension system.

WHAT is this pull request doing?

  • Creates a new AdminSpecIdentifier constant and corresponding specification file for admin extensions
  • Replaces the hardcoded 'admin' string with the proper AdminSpecIdentifier in the configuration extension IDs array
  • Adds the admin specification to the loaded specifications list
  • Implements admin extension as a contract-based module with single UID strategy and copy files build mode
  • Adds a default case to the extension instance UID generation logic
  • Updates the app configuration schema contribution logic to handle specifications without shape definitions
  • Adds uidStrategy parameter support to contract-based module specifications

How to test your changes?

  1. Create an admin extension in a Shopify app
  2. Verify the extension builds and deploys correctly
  3. Confirm the extension receives a proper UID based on its specification identifier
  4. Test that the hosted app copy files step executes during deployment

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

Copy link
Contributor Author

alfonso-noriega commented Mar 17, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@alfonso-noriega alfonso-noriega force-pushed the add_admin_config_local_spec branch from a25fc78 to f1ff200 Compare March 17, 2026 11:02
@alfonso-noriega alfonso-noriega force-pushed the add_manifest_to_include_files_step branch from 0fd3c26 to 141233b Compare March 17, 2026 11:03
@alfonso-noriega alfonso-noriega force-pushed the add_admin_config_local_spec branch from f1ff200 to 31060ea Compare March 17, 2026 11:07
@alfonso-noriega alfonso-noriega force-pushed the add_manifest_to_include_files_step branch from 141233b to 06bccee Compare March 17, 2026 11:07
@alfonso-noriega alfonso-noriega force-pushed the add_admin_config_local_spec branch from 31060ea to c22afce Compare March 17, 2026 11:19
@alfonso-noriega alfonso-noriega force-pushed the add_manifest_to_include_files_step branch 2 times, most recently from d13b2b2 to ef2ca4e Compare March 17, 2026 11:20
@alfonso-noriega alfonso-noriega force-pushed the add_admin_config_local_spec branch from c22afce to 178b934 Compare March 17, 2026 11:20
alfonso-noriega and others added 2 commits March 17, 2026 13:58
@alfonso-noriega alfonso-noriega force-pushed the add_manifest_to_include_files_step branch from ef2ca4e to 9c06d65 Compare March 17, 2026 15:51
@alfonso-noriega alfonso-noriega force-pushed the add_admin_config_local_spec branch from 178b934 to 010e9ae Compare March 17, 2026 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant