Clean up ExtensionSpecification spreads and mutations#7028
Draft
isaacroldan wants to merge 1 commit into03-17-exploration_make_extensionspecification_a_classfrom
Draft
Conversation
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
5 tasks
Replace object spread patterns and direct mutations with class methods: - Add applyRemoteSpecification() to apply remote API overrides - Add markAsRemoteLoaded() for tests needing the type marker - Split unifiedConfigurationParserFactory params (spec + remoteSpec) - Pass uidStrategy at construction via createContractBasedModuleSpecification - Remove leaked remote fields (name) from test assertions Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
isaacroldan
force-pushed
the
03-17-exploration_make_extensionspecification_a_class
branch
from
4048394 to
c0b1e0e
Compare
isaacroldan
force-pushed
the
03-17-clean_up_extensionspecification_spreads_and_mutations
branch
from
fcb5b57 to
1777ba0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #0000
WHAT is this pull request doing?
How to test your changes?
Post-release steps
Measuring impact
How do we know this change was effective? Please choose one:
Checklist