stop trying to resubscribe after max attempts#7058
Closed
craigmichaelmartin wants to merge 1 commit into03-19-fix_infinite_401_retry_loop_when_app_logs_resubscribe_failsfrom
Closed
Conversation
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
5 tasks
Contributor
|
We detected some changes at Caution DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release. |
Contributor
Author
|
Decided to just fold this into #7055 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

WHY are these changes introduced?
App log streaming sessions can become unstable due to network issues or authentication problems, causing repeated resubscribe failures that result in poor user experience with continuous retry attempts.
WHAT is this pull request doing?
Adds a maximum limit of 5 consecutive resubscribe failures before stopping app log polling and displaying a user-friendly message to restart the dev session. The implementation:
MAX_CONSECUTIVE_RESUBSCRIBE_FAILURESconstant set to 5How to test your changes?
Measuring impact
How do we know this change was effective? Please choose one:
Checklist