Expose structured app validation issues in JSON output#7070
Draft
dmerand wants to merge 3 commits intodlm-app-validate-errorsfrom
Draft
Expose structured app validation issues in JSON output#7070dmerand wants to merge 3 commits intodlm-app-validate-errorsfrom
dmerand wants to merge 3 commits intodlm-app-validate-errorsfrom
Conversation
This was referenced Mar 20, 2026
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
Coverage report
Test suite run success3936 tests passing in 1506 suites. Report generated by 🧪jest coverage report action from 9b0ba08 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Expose structured validation issues in
shopify app validate --json.This changes the public JSON response from a flat list of rendered error strings to a file-oriented
{valid, issues}shape, and keeps that shape consistent when validation fails before the normal service path runs.Why
Goal 3 work needs a stable machine-readable validation contract.
The human-readable output is fine for interactive use, but it is not a reliable interface for automation or repair loops. The command also needs to return JSON even when app loading aborts before
validateApp()can render the result.How
Use the structured issues preserved in the lower stack PR to emit a public
issuesarray.When only rendered text is available, synthesize a
rootissue so file-level context is not lost. For early aborts, parse the abort message into the same JSON shape and strip ANSI so colored terminal output does not leak into JSON strings.Testing
Run
shopify app validate --jsonagainst invalid app configs and confirm failures return{valid: false, issues: [...]}for both normal validation errors and early loader-style aborts.