Fix flaky tests and improve the main workflow#7102
Merged
gonzaloriestra merged 2 commits intomainfrom Mar 26, 2026
Merged
Conversation
Contributor
Coverage report
Test suite run success3929 tests passing in 1512 suites. Report generated by 🧪jest coverage report action from da23406 |
Contributor
|
We detected some changes at Caution DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release. |
isaacroldan
approved these changes
Mar 26, 2026
Contributor
Author
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
There are some flaky tests:
Also, the main checks are more unstable than the PR ones.
WHAT is this pull request doing?
downloadBinaryfrom./binaries.jswas never mocked, causing real HTTP requests to download WASM binaries on CI. Added a partial mock to stub it as a no-op.server.listen()calls were not awaited, so target servers could be unreachable when the proxy forwards the first request. The proxy's error handler logged warnings but never responded to the client, hangingfetch()forever. Wrapped alllisten()/close()calls in promises.--pool forkson macOS to matchtests-pr.yml, preventing thread-level resource contention that contributed to flakiness only on main.How to test your changes?
CI
Measuring impact
How do we know this change was effective? Please choose one:
Checklist