feat: pass clientSteps through in contract-based module specification#7141
Conversation
Co-authored-by: Claude Code <claude-code@anthropic.com>
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
We detected some changes at Caution DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release. |
There was a problem hiding this comment.
Pull request overview
This PR ensures contract-based module specifications preserve clientSteps so downstream build/deploy logic can execute the intended client step pipeline for those modules.
Changes:
- Pass
clientStepsthrough fromcreateContractBasedModuleSpecificationintocreateExtensionSpecification.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
isaacroldan
deleted the
04-01-feat_pass_clientsteps_through_in_contract-based_module_specification
branch
| appModuleFeatures: spec.appModuleFeatures, | ||
| experience: spec.experience, | ||
| buildConfig: spec.buildConfig ?? {mode: 'none'}, | ||
| clientSteps: spec.clientSteps, |
There was a problem hiding this comment.
Thanks for fixing this. Could we add a unit test to prevent the same issue from resurfacing?
…on factories Ensures clientSteps is properly forwarded in createContractBasedModuleSpecification, createExtensionSpecification, and createConfigExtensionSpecification. Prevents regression of the bug fixed in #7141 where clientSteps was accidentally dropped from createContractBasedModuleSpecification during a conflict resolution, breaking channel_config extension builds.
WHY are these changes introduced?
Fixes #0000
WHAT is this pull request doing?
How to test your changes?
Post-release steps
Measuring impact
How do we know this change was effective? Please choose one:
Checklist