Cleanup some unnecessary logs during dev#7142
Conversation
996b055 to
206be79
Compare
924bdd5 to
a8ac7f4
Compare
|
We detected some changes at Caution DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release. |
There was a problem hiding this comment.
Pull request overview
This PR reduces build-time console noise in the app build pipeline by removing per-step “Executing step” logging and moving some informational stdout messages (skipped config keys, manifest generation) to debug-level logging.
Changes:
- Removed
Executing step: ...stdout logging fromexecuteStep. - Replaced direct
stdout.write(...)messages for “no config key value” and “manifest generated” withoutputDebug(...). - Updated tests to stop asserting on the removed/changed stdout output.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/app/src/cli/services/build/steps/include-assets/generate-manifest.ts | Switch “Generated manifest…” message from stdout to debug logging. |
| packages/app/src/cli/services/build/steps/include-assets/copy-config-key-entry.ts | Switch “No value for configKey…” message from stdout to debug logging. |
| packages/app/src/cli/services/build/steps/include-assets/copy-config-key-entry.test.ts | Adjust tests to no longer assert on the removed stdout message. |
| packages/app/src/cli/services/build/steps/include-assets-step.test.ts | Remove assertion tied to the config-key stdout message. |
| packages/app/src/cli/services/build/client-steps.ts | Remove per-step “Executing step” stdout logging. |
| packages/app/src/cli/services/build/client-steps.test.ts | Remove test that asserted the per-step stdout logging. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/app/src/cli/services/build/steps/include-assets/copy-config-key-entry.ts
Outdated
Show resolved
Hide resolved
packages/app/src/cli/services/build/steps/include-assets/generate-manifest.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Claude Code <claude-code@anthropic.com>
a8ac7f4 to
bc25d3a
Compare
There was a problem hiding this comment.
📐 Design: The function takes both context: BuildContext (inside config) and a separate options: {stdout} parameter. Since context.options already carries stdout, the second parameter is redundant — every caller passes context.options as the second argument. The inconsistency in the new outputDebug call (reaching for context.options.stdout instead of options.stdout) highlights this duplication.
Suggestion: Consider removing the options parameter and using context.options.stdout (or a local alias) throughout the function. This would require updating the call site in include-assets-step.ts and the test helper, so it may be better suited for a follow-up.

WHY are these changes introduced?
The build process was outputting verbose logging messages directly to stdout, which clutters the console output and makes it harder for users to see important information during builds.
WHAT is this pull request doing?
outputDebugcalls for config key processing and manifest generation messagesHow to test your changes?
Measuring impact
How do we know this change was effective? Please choose one:
Checklist