Skip to content

Fix eslint config#7199

Merged
gonzaloriestra merged 2 commits intomainfrom
fix-eslint-config
Apr 7, 2026
Merged

Fix eslint config#7199
gonzaloriestra merged 2 commits intomainfrom
fix-eslint-config

Conversation

@gonzaloriestra
Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

ESLint's globber didn't recurse ** properly, so files under src/cli/commands/ and src/cli/services/ were never linted

WHAT is this pull request doing?

  • Fix lint configuration to pass src directory instead of "src/**/*.ts" glob
  • Fix all pre-existing lint violations now caught by recursive linting

How to test your changes?

CI

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

@gonzaloriestra gonzaloriestra marked this pull request as ready for review April 6, 2026 12:11
@gonzaloriestra gonzaloriestra requested a review from a team as a code owner April 6, 2026 12:11
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 6, 2026

We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run pnpm changeset add to track your changes and include them in the next release CHANGELOG.

Caution

DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release.

@gonzaloriestra gonzaloriestra added this pull request to the merge queue Apr 7, 2026
Merged via the queue into main with commit dbcb9d6 Apr 7, 2026
25 of 26 checks passed
@gonzaloriestra gonzaloriestra deleted the fix-eslint-config branch April 7, 2026 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants