Skip to content

Fix flaky runWithRateLimit test by using fake timers #7290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gonzaloriestra merged 1 commit into from
Apr 14, 2026
+2 −0
Merged

Fix flaky runWithRateLimit test by using fake timers #7290

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/cli-kit/src/private/node/conf-store.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,6 +474,7 @@ describe('runWithRateLimit', () => {
test('throttles the task when the cache is populated recently', async () => {
await inTemporaryDirectory(async (cwd) => {
// Given
vi.useFakeTimers()
const config = new LocalStorage<any>({cwd})
for (let i = 0; i < limit; i++) {
// eslint-disable-next-line no-await-in-loop
Expand Down Expand Up @@ -511,6 +512,7 @@ describe('runWithRateLimit', () => {
test("runs the task as usual when the cache is populated recently but the rate limit isn't used up", async () => {
await inTemporaryDirectory(async (cwd) => {
// Given
vi.useFakeTimers()
const config = new LocalStorage<any>({cwd})
// Run the task once, but the rate limit is 2
await runWithRateLimit(
Expand Down
Loading