Skip to content

Upgrade Node version in update-graphql-deps.yml#7306

Merged
gonzaloriestra merged 1 commit intomainfrom
fix-flaky-graphql-codegen-check
Apr 15, 2026
Merged

Upgrade Node version in update-graphql-deps.yml#7306
gonzaloriestra merged 1 commit intomainfrom
fix-flaky-graphql-codegen-check

Conversation

@gonzaloriestra
Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

There's a Node version mismatch between workflows:

  • update-graphql-deps.yml generates and commits codegen output using Node 22.11.0
  • tests-pr.yml re-generates and verifies those files using Node 24.1.0

The codegen pipeline includes an eslint --fix formatting step (graphql-codegen:formatting), which can produce subtly different output across Node versions. So files committed by the update workflow (Node 22) don't always match what the PR check regenerates (Node 24) — even with identical schemas and queries.

This explains the flakiness: eslint --fix is mostly stable across Node versions, but occasionally produces different formatting for certain files.

More info: https://shopify.slack.com/archives/C05E3BDFDRB/p1776201817435039

WHAT is this pull request doing?

Updates the Node version in update-graphql-deps.yml to match other workflows

How to test your changes?

Merge and run it

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing, so I've added a changelog entry with pnpm changeset add

@gonzaloriestra gonzaloriestra requested a review from a team as a code owner April 15, 2026 11:44
Copy link
Copy Markdown
Contributor Author

gonzaloriestra commented Apr 15, 2026

Merge activity

  • Apr 15, 12:10 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Apr 15, 12:11 PM UTC: @gonzaloriestra added this pull request to the GitHub merge queue with Graphite.

@gonzaloriestra gonzaloriestra added this pull request to the merge queue Apr 15, 2026
Merged via the queue into main with commit 1b1a0f4 Apr 15, 2026
25 checks passed
@gonzaloriestra gonzaloriestra deleted the fix-flaky-graphql-codegen-check branch April 15, 2026 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants