Upgrade Node version in update-graphql-deps.yml#7306
Merged
gonzaloriestra merged 1 commit intomainfrom Apr 15, 2026
Merged
Conversation
byrichardpowell
approved these changes
Apr 15, 2026
Contributor
Author
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
There's a Node version mismatch between workflows:
The codegen pipeline includes an eslint --fix formatting step (graphql-codegen:formatting), which can produce subtly different output across Node versions. So files committed by the update workflow (Node 22) don't always match what the PR check regenerates (Node 24) — even with identical schemas and queries.
This explains the flakiness: eslint --fix is mostly stable across Node versions, but occasionally produces different formatting for certain files.
More info: https://shopify.slack.com/archives/C05E3BDFDRB/p1776201817435039
WHAT is this pull request doing?
Updates the Node version in update-graphql-deps.yml to match other workflows
How to test your changes?
Merge and run it
Checklist
pnpm changeset add