Open
Conversation
Member
Author
|
/snapit |
Contributor
|
🫰✨ Thanks @vividviolet! Your snapshot has been published to npm. Test the snapshot by installing your package globally: pnpm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20260417020303Caution After installing, validate the version by running |
ba0ec3f to
521ad24
Compare
vividviolet
commented
Apr 17, 2026
| return this.specification.getOutputRelativePath?.(this) ?? '' | ||
| } | ||
|
|
||
| get localOutputPath() { |
Member
Author
There was a problem hiding this comment.
This was being repeated everywhere so I made a getter for it
vividviolet
commented
Apr 17, 2026
| url: `${url}/assets/${extension.outputFileName}`, | ||
| lastUpdated: (await fileLastUpdatedTimestamp(extensionOutputPath)) ?? 0, | ||
| }, | ||
| // Always use the local output path for the main asset |
Member
Author
There was a problem hiding this comment.
This fixes a bug where the main asset appears to always update even though the JS files have not changed
521ad24 to
ba7782c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

WHY are these changes introduced?
The manifest.json was being generated inside
/disteven though/distshould only affect thebundle_uistep. Manifest files should be generated in the root of the bundle for consistency.Before
admin_link
ui_extension

After
admin_link (unchanged)
ui_extension
WHAT is this pull request doing?
bundleRootproperty toExtensionInstanceto track the root directory for bundled extensionslocalOutputPathgetter that consistently resolves the extension's local output pathbuildForBundleandcopyIntoBundlemethods to usebundleRootfor determining bundle locationsbundleRootinstead of output directorymanifest.jsontobundleRootbundlePathparameter from payload generation functions since extensions now track their own bundle locationsChecklist
pnpm changeset add