E2E: trial for more workers + shards#7350
Open
phyllis-sy-wu wants to merge 1 commit intopsyw-0414-E2E-parallel-workersfrom
Open
E2E: trial for more workers + shards#7350phyllis-sy-wu wants to merge 1 commit intopsyw-0414-E2E-parallel-workersfrom
phyllis-sy-wu wants to merge 1 commit intopsyw-0414-E2E-parallel-workersfrom
Conversation
This was referenced Apr 20, 2026
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/upgrade.d.ts@@ -1,5 +1,3 @@
-import { getAutoUpgradeEnabled, setAutoUpgradeEnabled } from '../../private/node/conf-store.js';
-export { getAutoUpgradeEnabled, setAutoUpgradeEnabled };
/**
* Utility function for generating an install command for the user to run
* to install an updated version of Shopify CLI.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

WHY are these changes introduced?
Evaluate whether combining more workers (10) with sharding (2 CI machines) gives the best E2E runtime, since each shard gets its own 4 vCPU runner — avoiding the contention that hurt 10 workers on a single machine.
CI runner specs:
ubuntu-latest= 4 vCPUs, 16 GB RAM (GitHub docs).WHAT is this pull request doing?
playwright.config.tsshard: ['1/2', '2/2']to the E2E CI jobBenchmark Results:
(under stable conditions, very few teardown failures or flaky retries)
7m 41s (shard 2/2)
5m 48s (shard 2/2)
10 workers + 2 shards vs 5 workers + 1 shard (baseline #7309):
Pros:
Cons:
Note: Total number of stores/apps created is the same regardless of workers/shards — it's determined by the number of tests. More workers/shards only increases how many run concurrently, not the total count.
How to test your changes?
Compare CI run times across all four trial PRs.
Post-release steps
N/A — trial branch, not intended to merge.
Checklist
pnpm changeset add