Skip to content

Extract GraphiQL server to @shopify/cli-kit#7379

Draft
gonzaloriestra wants to merge 1 commit intomainfrom
graphiql-store/extract-to-cli-kit
Draft

Extract GraphiQL server to @shopify/cli-kit#7379
gonzaloriestra wants to merge 1 commit intomainfrom
graphiql-store/extract-to-cli-kit

Conversation

@gonzaloriestra
Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

Fixes #0000

WHAT is this pull request doing?

How to test your changes?

Post-release steps

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type (patch for bug fixes · minor for new features · major for breaking changes) and added a changeset with pnpm changeset add

Copy link
Copy Markdown
Contributor Author

gonzaloriestra commented Apr 23, 2026

@gonzaloriestra gonzaloriestra changed the title chore: extract GraphiQL server to @shopify/cli-kit Extract GraphiQL server to @shopify/cli-kit Apr 23, 2026
Move the GraphiQL HTTP proxy and its templates/assets out of @shopify/app
and into @shopify/cli-kit so other packages (notably @shopify/store) can
reuse it.

This commit is purely mechanical:
- Files moved to packages/cli-kit/src/public/node/graphiql/ and
  packages/cli-kit/assets/graphiql/.
- Imports inside the moved server now use relative paths to other cli-kit
  modules instead of cross-package @shopify/cli-kit/* imports.
- Asset resolution switched to @shopify/cli-kit/assets/graphiql/*.
- @shopify/app consumers updated to import from
  @shopify/cli-kit/node/graphiql/server.
- cli-kit package.json gains h3, @shopify/polaris, @shopify/polaris-icons,
  and react-dom (with @types/react-dom in devDependencies).

Behavior is unchanged. Existing graphiql server.test.ts and utilities.test.ts
move alongside the source.
@gonzaloriestra gonzaloriestra force-pushed the graphiql-store/extract-to-cli-kit branch from 2cf7228 to 9fd0733 Compare April 23, 2026 12:23
@github-actions
Copy link
Copy Markdown
Contributor

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

packages/cli-kit/dist/public/node/graphiql/server.d.ts
import { Server } from 'http';
import { Writable } from 'stream';
/**
 * Derives a deterministic GraphiQL authentication key from the app's API secret and store FQDN.
 * The key is stable across dev server restarts (so browser tabs survive restarts)
 * but is not guessable without the app secret.
 *
 * @param apiSecret - The Partners app's client secret used as the HMAC key.
 * @param storeFqdn - The myshopify.com domain the GraphiQL session targets.
 * @returns A 64-character hex string suitable for use as the `?key=` query param.
 */
export declare function deriveGraphiQLKey(apiSecret: string, storeFqdn: string): string;
/**
 * Resolves the GraphiQL authentication key. Uses the explicitly provided key
 * if non-empty, otherwise derives one deterministically from the app secret.
 *
 * @param providedKey - An explicit key supplied by the caller; takes precedence when non-empty.
 * @param apiSecret - The Partners app's client secret, used to derive a stable key as a fallback.
 * @param storeFqdn - The myshopify.com domain the GraphiQL session targets.
 * @returns The resolved key.
 */
export declare function resolveGraphiQLKey(providedKey: string | undefined, apiSecret: string, storeFqdn: string): string;
interface SetupGraphiQLServerOptions {
    stdout: Writable;
    port: number;
    appName: string;
    appUrl: string;
    apiKey: string;
    apiSecret: string;
    key?: string;
    storeFqdn: string;
}
/**
 * Starts a local HTTP server that hosts the GraphiQL UI and proxies requests to the
 * Admin API for the configured store. The server uses the OAuth `client_credentials`
 * grant with the supplied `apiKey` / `apiSecret` to mint and refresh access tokens
 * on the fly.
 *
 * @param options - Configuration for the server, including the target store, the
 * Partners app credentials, and the local port to bind to.
 * @returns The underlying Node `http.Server` instance, already listening on `options.port`.
 */
export declare function setupGraphiQLServer(options: SetupGraphiQLServerOptions): Server;
export {};
packages/cli-kit/dist/public/node/graphiql/utilities.d.ts
/**
 * Filters request headers to extract only custom headers that are safe to forward.
 * Blocked headers and non-string values are excluded.
 *
 * @param headers - The raw incoming request headers.
 * @returns The subset of headers that are safe to forward to the Admin API.
 */
export declare function filterCustomHeaders(headers: {
    [key: string]: string | string[] | undefined;
}): {
    [key: string]: string;
};
packages/cli-kit/dist/public/node/graphiql/templates/graphiql.d.ts
export declare const defaultQuery: string;
interface GraphiQLTemplateOptions {
    apiVersion: string;
    apiVersions: string[];
    appName: string;
    appUrl: string;
    key: string;
    storeFqdn: string;
}
export declare function graphiqlTemplate({ apiVersion, apiVersions, appName, appUrl, key, storeFqdn, }: GraphiQLTemplateOptions): string;
export {};
packages/cli-kit/dist/public/node/graphiql/templates/unauthorized.d.ts
export declare const unauthorizedTemplate: string;

Existing type declarations

We found no diffs with existing type declarations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant