Skip to content

Fix web pixel bundle_ui step#7398

Merged
vividviolet merged 1 commit intomainfrom
04-24-fix_web_pixel_bundle_ui_step
Apr 24, 2026
Merged

Fix web pixel bundle_ui step#7398
vividviolet merged 1 commit intomainfrom
04-24-fix_web_pixel_bundle_ui_step

Conversation

@vividviolet
Copy link
Copy Markdown
Member

@vividviolet vividviolet commented Apr 24, 2026

WHY are these changes introduced?

The bundle_ui step needs to control where the bundled output is placed, rather than having the output path hardcoded into the relative path returned by getOutputRelativePath.

Before

image.png

After

image.png

WHAT is this pull request doing?

Moves the dist/ folder prefix from getOutputRelativePath into the bundle_ui step configuration via a bundleFolder config property. This allows the bundling step to own the output directory while getOutputRelativePath returns just the filename (${extension.handle}.js).

How to test your changes?

  1. Deploy a web pixel extension and verify the bundled output is still placed in the dist/ folder.
  2. Confirm the output file is correctly referenced as ${handle}.js without the dist/ prefix in the relative path.

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type (patch for bug fixes · minor for new features · major for breaking changes) and added a changeset with pnpm changeset add

Copy link
Copy Markdown
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@vividviolet vividviolet marked this pull request as ready for review April 24, 2026 18:47
@vividviolet vividviolet requested a review from a team as a code owner April 24, 2026 18:47
@vividviolet vividviolet added this pull request to the merge queue Apr 24, 2026
Merged via the queue into main with commit c981ee0 Apr 24, 2026
27 checks passed
@vividviolet vividviolet deleted the 04-24-fix_web_pixel_bundle_ui_step branch April 24, 2026 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants