Skip manifest generation when bundle dir matches local output

[isaacroldan]

WHY are these changes introduced?

When the local output directory and the bundle output directory resolve to the same path, there is no need to copy files or generate an assets manifest. Previously, the early return only skipped the file copy but still allowed manifest generation to proceed in some code paths.

WHAT is this pull request doing?

When the resolved local and bundle output directories are identical, the function now returns early before both the file copy and any manifest generation. This ensures that manifest generation is also skipped in this case, not just the file copy.

A test has been added to verify that neither copyFile nor createOrUpdateManifestFile is called when the two paths resolve to the same location.

How to test your changes?

1. Run the updated test suite for bundle-ui-step:

   pnpm test packages/app/src/cli/services/build/steps/bundle-ui-step.test.ts
   

2. Verify the new test case passes, confirming that both copyFile and createOrUpdateManifestFile are skipped when the local and bundle output directories resolve to the same path.

Checklist

• I've considered possible cross-platform impacts (Mac, Linux, Windows)
• I've considered possible documentation changes
• I've considered analytics changes to measure impact
• The change is user-facing — I've identified the correct bump type (patch for bug fixes · minor for new features · major for breaking changes) and added a changeset with pnpm changeset add

[isaacroldan]

• Skip manifest generation when bundle dir matches local output #7413 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[Copilot]

Pull request overview

Updates the bundle_ui build step to fully short-circuit when the “local build output” and “bundle output” directories resolve to the same path, preventing unnecessary work and avoiding manifest generation in that scenario.

Changes:

• Return early when resolvePath(localOutputDir) === resolvePath(bundleOutputDir) to skip both copy and manifest generation.
• Simplify copy logic to a single unconditional copyFile call after the early-return guard.
• Add a unit test asserting neither copyFile nor createOrUpdateManifestFile is invoked when both paths resolve to the same location.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
packages/app/src/cli/services/build/steps/bundle-ui-step.ts	Adds an early return to skip copy + assets manifest generation when output dirs resolve to the same path.
packages/app/src/cli/services/build/steps/bundle-ui-step.test.ts	Adds coverage ensuring manifest generation is also skipped in the “same resolved dir” scenario.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.